-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate keycard interaction animation with keycard flows #10015
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (75)
|
I know it's very WIP, builds just failed on unit tests |
47b2657
to
abfaa3a
Compare
Tested with Galaxy s10e. Encountered no issues. Great work! |
bee04e0
to
db8bbb2
Compare
56740bb
to
60257a1
Compare
09fcc1d
to
5334b82
Compare
#9365, #9334, #9702, #9660 are fixed. Generally: card states look amazing! Issue 1: can't finish card paring: redirect to 1 step after backing up seed phraseSteps:
Not possible to finish pairing card - after backing up seed phrase you redirected to 1 step (entering PIN) - like it is mentioned in issue #9704 If I start canceling on this screen, it will redirect me again to Step 3 - confirm your seed phrase (word number...) The same happened after reopening app. So basically there is now way after #9704 to finish setup with this card. Issue 2: still not able to create multiaccount after #9676Steps:
Expected result: Actual result:
|
Issue #9665 is still reproducible |
@rasom yes, we can, but currently according to Issue 2 #10015 (comment) - user can't finish setup and card is dead (like it is in #9764) So maybe it is better to prevent users to use this flow (i.e. leave only "Cancel" for now and add some text for clarification) #9665 absolutely can fix separately - it is just mentioned in PR as fixed. |
eedd506
to
d110507
Compare
@Ferossgp As for issue 1: in #9702 workflow is still broken if canceling setup on "Pairing code and PUK" - in builds with d110507 if you tap on "Cancel", you will be redirected to 1 step (entering PIN) - and can't proceed. Logs: |
It is fixed for happy-path scenario, however if you enter wrong pin after back up seed phrase, workflow will be broken. It is huge piece of work, @Ferossgp . |
Remove screens that are not needed for new flow Replace keycard flows with new interaction If card connected start processing on sheet open Remove outdated pin screens Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com> Do not hide sheet when tag was lost during generating keys Change cancel action for no-key on card recovery Change pin screen when loading keys to an initialised card Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
0cb47a6
to
826b7df
Compare
This PR replaces all screens which were related to keycard connection with a bottom sheet. Before when interaction with the card was required we used to navigate to a screen which says to connect card, during errors and lost of the connection we navigate to other screens. Now all that is handled in the same sheet by animating to different states.
Fixes #9365
Fixes #9704
Fixes #9676
Fixes #9660
Fixes #9664
Fixes #9626
Fixes #9702
Fixes #9334
To be checked: #9451 #10023 #10032