Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate keycard interaction animation with keycard flows #10015

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

Ferossgp
Copy link
Contributor

@Ferossgp Ferossgp commented Feb 10, 2020

This PR replaces all screens which were related to keycard connection with a bottom sheet. Before when interaction with the card was required we used to navigate to a screen which says to connect card, during errors and lost of the connection we navigate to other screens. Now all that is handled in the same sheet by animating to different states.
Fixes #9365
Fixes #9704
Fixes #9676
Fixes #9660
Fixes #9664
Fixes #9626
Fixes #9702
Fixes #9334

To be checked: #9451 #10023 #10032

@Ferossgp Ferossgp requested a review from a team as a code owner February 10, 2020 15:27
@Ferossgp Ferossgp requested a review from a team February 10, 2020 15:27
@Ferossgp Ferossgp self-assigned this Feb 10, 2020
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Feb 10, 2020

Jenkins Builds

Click to see older builds (75)
Commit #️⃣ Finished (UTC) Duration Platform Result
d907c8d #1 2020-02-10 15:37:17 ~9 min ios 📄log
d907c8d #1 2020-02-10 15:43:27 ~16 min android-e2e 📄log
d907c8d #1 2020-02-10 15:43:39 ~16 min android 📄log
a690733 #2 2020-02-11 10:10:07 ~2 min ios 📄log
a690733 #2 2020-02-11 10:11:34 ~4 min android 📄log
a690733 #2 2020-02-11 10:11:38 ~4 min android-e2e 📄log
4e37a64 #3 2020-02-11 11:09:12 ~10 min ios 📄log
4e37a64 #3 2020-02-11 11:12:15 ~13 min android-e2e 📄log
4e37a64 #3 2020-02-11 11:12:31 ~13 min android 📄log
✔️ a4300df #4 2020-02-11 11:36:32 ~10 min ios 📦ipa 📲
✔️ a4300df #4 2020-02-11 11:41:25 ~15 min android-e2e 📦apk 📲
✔️ a4300df #4 2020-02-11 11:41:25 ~15 min android 📦apk 📲
47b2657 #5 2020-02-11 11:51:28 ~3 min ios 📄log
47b2657 #5 2020-02-11 11:54:16 ~6 min android 📄log
47b2657 #5 2020-02-11 12:02:45 ~15 min android-e2e 📄log
✔️ abfaa3a #6 2020-02-11 12:15:57 ~10 min ios 📦ipa 📲
✔️ abfaa3a #6 2020-02-11 12:31:59 ~26 min android-e2e 📦apk 📲
✔️ abfaa3a #7 2020-02-11 12:57:33 ~12 min android 📦apk 📲
✔️ 568b7ae #7 2020-02-13 08:46:06 ~10 min ios 📦ipa 📲
✔️ 568b7ae #7 2020-02-13 08:50:22 ~15 min android-e2e 📦apk 📲
✔️ 568b7ae #8 2020-02-13 08:50:22 ~15 min android 📦apk 📲
✔️ 4c80ad9 #8 2020-02-13 09:57:35 ~11 min ios 📦ipa 📲
✔️ 4c80ad9 #8 2020-02-13 10:01:16 ~14 min android-e2e 📦apk 📲
✔️ 4c80ad9 #9 2020-02-13 10:01:16 ~14 min android 📦apk 📲
✔️ 340b37b #9 2020-02-14 14:11:49 ~9 min ios 📦ipa 📲
✔️ 340b37b #10 2020-02-14 14:16:07 ~14 min android 📦apk 📲
✔️ 340b37b #9 2020-02-14 14:16:07 ~14 min android-e2e 📦apk 📲
✔️ 12c5653 #10 2020-02-14 14:57:14 ~11 min ios 📦ipa 📲
✔️ 12c5653 #10 2020-02-14 15:00:25 ~14 min android-e2e 📦apk 📲
✔️ 12c5653 #11 2020-02-14 15:00:25 ~14 min android 📦apk 📲
80708b2 #11 2020-02-14 16:43:14 ~44 sec android-e2e 📄log
80708b2 #12 2020-02-14 16:43:18 ~47 sec android 📄log
80708b2 #11 2020-02-14 16:43:24 ~52 sec ios 📄log
bee04e0 #12 2020-02-15 16:23:41 ~3 min android-e2e 📄log
bee04e0 #13 2020-02-15 16:23:44 ~3 min android 📄log
bee04e0 #12 2020-02-15 16:24:13 ~4 min ios 📄log
✔️ db8bbb2 #13 2020-02-15 16:41:31 ~11 min ios 📦ipa 📲
✔️ db8bbb2 #13 2020-02-15 16:44:56 ~14 min android-e2e 📦apk 📲
✔️ db8bbb2 #14 2020-02-15 16:44:57 ~14 min android 📦apk 📲
✔️ d3458d2 #14 2020-02-18 15:33:04 ~11 min ios 📦ipa 📲
✔️ d3458d2 #14 2020-02-18 15:38:40 ~17 min android-e2e 📦apk 📲
✔️ d3458d2 #15 2020-02-18 15:38:40 ~17 min android 📦apk 📲
✔️ 56740bb #15 2020-02-19 09:14:07 ~11 min ios 📦ipa 📲
✔️ 56740bb #16 2020-02-19 09:18:28 ~16 min android 📦apk 📲
✔️ 56740bb #15 2020-02-19 09:18:28 ~16 min android-e2e 📦apk 📲
✔️ 60257a1 #16 2020-02-19 14:26:28 ~11 min ios 📦ipa 📲
✔️ 60257a1 #16 2020-02-19 14:32:46 ~17 min android-e2e 📦apk 📲
✔️ 60257a1 #17 2020-02-19 14:32:46 ~17 min android 📦apk 📲
✔️ 8ea0175 #17 2020-02-24 15:06:39 ~9 min ios 📦ipa 📲
✔️ 8ea0175 #17 2020-02-24 15:13:52 ~17 min android-e2e 📦apk 📲
✔️ 8ea0175 #18 2020-02-24 15:13:52 ~17 min android 📦apk 📲
✔️ 0e10578 #18 2020-02-25 10:34:01 ~9 min ios 📦ipa 📲
✔️ 0e10578 #18 2020-02-25 10:39:12 ~15 min android-e2e 📦apk 📲
✔️ 0e10578 #19 2020-02-25 10:39:12 ~15 min android 📦apk 📲
✔️ bbbafa6 #19 2020-02-25 11:32:30 ~9 min ios 📦ipa 📲
✔️ bbbafa6 #19 2020-02-25 11:36:42 ~14 min android-e2e 📦apk 📲
✔️ bbbafa6 #20 2020-02-25 11:36:42 ~14 min android 📦apk 📲
✔️ 773772c #20 2020-02-25 14:59:16 ~12 min ios 📦ipa 📲
✔️ 773772c #20 2020-02-25 14:59:29 ~12 min android-e2e 📦apk 📲
✔️ 773772c #21 2020-02-25 15:12:35 ~25 min android 📦apk 📲
✔️ 1ffde18 #21 2020-02-26 12:07:19 ~11 min ios 📦ipa 📲
✔️ 1ffde18 #21 2020-02-26 12:08:19 ~12 min android-e2e 📦apk 📲
✔️ 1ffde18 #22 2020-02-26 12:15:14 ~19 min android 📦apk 📲
✔️ f5bcb29 #22 2020-02-28 13:21:08 ~11 min ios 📦ipa 📲
✔️ f5bcb29 #23 2020-02-28 13:23:55 ~14 min android 📦apk 📲
✔️ f5bcb29 #22 2020-02-28 13:23:55 ~14 min android-e2e 📦apk 📲
✔️ 09fcc1d #23 2020-03-01 09:30:14 ~14 min ios 📦ipa 📲
✔️ 09fcc1d #24 2020-03-01 09:31:16 ~15 min android 📦apk 📲
✔️ 09fcc1d #23 2020-03-01 09:31:16 ~15 min android-e2e 📦apk 📲
✔️ 5334b82 #24 2020-03-10 07:28:46 ~9 min ios 📦ipa 📲
✔️ 5334b82 #24 2020-03-10 07:31:30 ~12 min android-e2e 📦apk 📲
✔️ 5334b82 #25 2020-03-10 07:31:36 ~12 min android 📦apk 📲
eedd506 #25 2020-03-11 09:43:10 ~9 min ios 📄log
eedd506 #26 2020-03-11 09:51:00 ~17 min android 📄log
eedd506 #25 2020-03-11 09:52:37 ~18 min android-e2e 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d110507 #26 2020-03-11 10:08:59 ~8 min ios 📦ipa 📲
✔️ d110507 #26 2020-03-11 10:16:49 ~16 min android-e2e 📦apk 📲
✔️ d110507 #27 2020-03-11 10:16:49 ~16 min android 📦apk 📲
✔️ 0cb47a6 #27 2020-03-11 12:16:14 ~9 min ios 📦ipa 📲
✔️ 0cb47a6 #27 2020-03-11 12:22:33 ~15 min android-e2e 📦apk 📲
✔️ 0cb47a6 #28 2020-03-11 12:22:40 ~15 min android 📦apk 📲

@flexsurfer flexsurfer removed request for a team February 10, 2020 15:41
@Serhy
Copy link
Contributor

Serhy commented Feb 10, 2020

I know it's very WIP, builds just failed on unit tests

@Ferossgp Ferossgp force-pushed the change-keycard-onboarding branch 5 times, most recently from 47b2657 to abfaa3a Compare February 11, 2020 12:05
@hesterbruikman
Copy link
Contributor

Tested with Galaxy s10e. Encountered no issues. Great work!

@Ferossgp Ferossgp force-pushed the change-keycard-onboarding branch 3 times, most recently from 56740bb to 60257a1 Compare February 19, 2020 14:15
@churik churik self-assigned this Mar 10, 2020
@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 96
Failed tests: 0
Passed tests: 96

Passed tests (96)

Click to expand
1. test_can_see_all_transactions_in_history
Device sessions

2. test_install_pack_and_send_sticker
Device sessions

3. test_send_message_in_group_chat
Device sessions

4. test_login_with_new_account
Device sessions

5. test_clear_history_of_group_chat_via_group_view
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_send_message_to_newly_added_contact
Device sessions

22. test_share_contact_code_and_wallet_address
Device sessions

23. test_make_admin_member_of_group_chat
Device sessions

24. test_connection_is_secure
Device sessions

25. test_add_to_contacts
Device sessions

26. test_add_account_to_multiaccount_instance_private_key
Device sessions

27. test_refresh_button_browsing_app_webview
Device sessions

28. test_long_press_to_delete_1_1_chat
Device sessions

29. test_can_add_existing_ens
Device sessions

30. test_transaction_wrong_password_wallet
Device sessions

31. test_public_chat_messaging
Device sessions

32. test_unread_messages_counter_public_chat
Device sessions

33. test_delete_one_to_one_chat_via_delete_button
Device sessions

34. test_long_press_to_delete_public_chat
Device sessions

35. test_text_message_1_1_chat
Device sessions

36. test_delete_public_chat_via_delete_button
Device sessions

37. test_can_use_purchased_stickers_on_recovered_account
Device sessions

38. test_open_transaction_on_etherscan
Device sessions

39. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

40. test_contact_profile_view
Device sessions

41. test_logcat_backup_recovery_phrase
Device sessions

42. test_delete_group_chat_via_delete_button
Device sessions

43. test_start_chat_with_ens
Device sessions

44. test_add_and_remove_contact_from_public_chat
Device sessions

45. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

46. test_open_blocked_site
Device sessions

47. test_open_chat_by_pasting_public_key
Device sessions

48. test_ens_username_recipient
Device sessions

49. test_token_with_more_than_allowed_decimals
Device sessions

50. test_fetch_more_history_in_empty_chat
Device sessions

51. test_switch_users_and_add_new_account
Device sessions

52. test_add_account_to_multiaccount_instance_generate_new
Device sessions

53. test_copy_contact_code_and_wallet_address
Device sessions

54. test_send_transaction_from_daap
Device sessions

55. test_send_two_transactions_one_after_another_in_dapp
Device sessions

56. test_message_marked_as_sent_in_1_1_chat
Device sessions

57. test_long_press_delete_clear_all_dapps
Device sessions

58. test_copy_and_paste_messages
Device sessions

59. test_deploy_contract_from_daap
Device sessions

60. test_back_forward_buttons_browsing_website
Device sessions

61. test_password_in_logcat_creating_account
Device sessions

62. test_add_custom_token
Device sessions

63. test_sign_message_from_daap
Device sessions

64. test_group_chat_system_messages
Device sessions

65. test_dapps_permissions
Device sessions

66. test_request_public_key_status_test_daap
Device sessions

67. test_logcat_send_transaction_from_wallet
Device sessions

68. test_log_level_and_fleet
Device sessions

69. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

70. test_recover_account_from_new_user_seedphrase
Device sessions

71. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

72. test_send_two_transactions_in_batch_in_dapp
Device sessions

73. test_ens_in_public_and_1_1_chats
Device sessions

74. test_block_user_from_public_chat
Device sessions

75. test_fetching_balance_after_offline
Device sessions

76. test_logcat_sign_message_from_daap
Device sessions

77. test_offline_status
Device sessions

78. test_wallet_set_up
Device sessions

79. test_manage_assets
Device sessions

80. test_add_new_group_chat_member
Device sessions

81. test_offline_messaging_1_1_chat
Device sessions

82. test_decline_invitation_to_group_chat
Device sessions

83. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

84. test_send_token_with_7_decimals
Device sessions

85. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

86. test_pass_phrase_validation
Device sessions

87. test_send_emoji
Device sessions

88. test_filters_from_daap
Device sessions

89. test_redirect_to_public_chat_tapping_tag_message
Device sessions

90. test_pair_devices_sync_one_to_one_contacts
Device sessions

91. test_logcat_send_transaction_from_daap
Device sessions

92. test_send_eth_from_wallet_to_address
Device sessions

93. test_send_stt_from_wallet
Device sessions

94. test_messaging_in_different_networks
Device sessions

95. test_collectible_from_wallet_opens_in_browser_view
Device sessions

96. test_insufficient_funds_wallet_positive_balance
Device sessions

@churik
Copy link
Member

churik commented Mar 10, 2020

#9365, #9334, #9702, #9660 are fixed.

Generally: card states look amazing!

Issue 1: can't finish card paring: redirect to 1 step after backing up seed phrase

Steps:

Not possible to finish pairing card - after backing up seed phrase you redirected to 1 step (entering PIN) - like it is mentioned in issue #9704

Status.log

If I start canceling on this screen, it will redirect me again to Step 3 - confirm your seed phrase (word number...)

The same happened after reopening app. So basically there is now way after #9704 to finish setup with this card.
It blocks verification of #9626.

Issue 2: still not able to create multiaccount after #9676

Steps:

Expected result:
can finish

Actual result:
tried 3 times - once got java exception, and endless spinner in other cases
Logs:

INFO [03-10|14:19:56.770] waiting for a card                       package=status-go/cmd/keycard
INFO [03-10|14:19:56.772] card found                               package=status-go/cmd/keycard index=0

@churik
Copy link
Member

churik commented Mar 10, 2020

Issue #9665 is still reproducible

@rasom
Copy link
Contributor

rasom commented Mar 10, 2020

@churik I believe we can fix #9676 and #9665 separately from this PR

@churik
Copy link
Member

churik commented Mar 10, 2020

@rasom yes, we can, but currently according to Issue 2 #10015 (comment) - user can't finish setup and card is dead (like it is in #9764)

So maybe it is better to prevent users to use this flow (i.e. leave only "Cancel" for now and add some text for clarification)

#9665 absolutely can fix separately - it is just mentioned in PR as fixed.

@churik
Copy link
Member

churik commented Mar 11, 2020

@Ferossgp
Issue 2 I consider as fixed because it is a consequence of another issue - I tried with 2 other cards and couldn't reproduce.

As for issue 1: in #9702 workflow is still broken if canceling setup on "Pairing code and PUK" - in builds with d110507 if you tap on "Cancel", you will be redirected to 1 step (entering PIN) - and can't proceed.

Logs:
geth.log
Status.log
App is stucking with endless spinner.

@churik
Copy link
Member

churik commented Mar 11, 2020

As for issue 1: in #9702 workflow is still broken if canceling setup on "Pairing code and PUK" - in builds with d110507 if you tap on "Cancel", you will be redirected to 1 step (entering PIN) - and can't proceed.

It is fixed for happy-path scenario, however if you enter wrong pin after back up seed phrase, workflow will be broken.
Regardless you can reopen app and complete setup, so issue is not critical and will be reported / fixed separately.

It is huge piece of work, @Ferossgp .
Thanks!

Remove screens that are not needed for new flow

Replace keycard flows with new interaction

If card connected start processing on sheet open

Remove outdated pin screens

Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>

Do not hide sheet when tag was lost during generating keys

Change cancel action for no-key on card recovery

Change pin screen when loading keys to an initialised card

Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment