Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in onboarding, when user defines the keycard PIN passcode, he's proposed a 'cancel button' #10032

Closed
guylouis opened this issue Feb 12, 2020 · 3 comments · Fixed by #12257
Closed
Assignees

Comments

@guylouis
Copy link
Contributor

guylouis commented Feb 12, 2020

in onboarding, when user defines the keycard PIN passcode, he's proposed a 'cancel button'

Screenshot_20200212-121325

when he types 'cancel' he gets a dangerous operation warning. It's not necessary and should be replaced by a back button

see logic here https://miro.com/app/board/o9J_kvIXxoU=/

@guylouis
Copy link
Contributor Author

guylouis commented Dec 1, 2020

01/12/2020 this issue is still relevant
see the dangerous operation screen that is shown here :
image

@bitgamma bitgamma self-assigned this Jun 22, 2021
@bitgamma
Copy link
Member

@guylouis is the dangerous operation warning needed anymore at any step of the setup? Even if we cancel after pairing, the pairing is stored and not wasted. Also since we have factory reset it is not really dangerous, you can always reset. My proposal is to completely remove this warning, wdyt?

@bitgamma
Copy link
Member

as discussed in the call, the warning will be removed altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants