Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cancel warning on Keycard onboarding #12257

Merged
merged 1 commit into from
Jun 29, 2021
Merged

remove cancel warning on Keycard onboarding #12257

merged 1 commit into from
Jun 29, 2021

Conversation

bitgamma
Copy link
Member

Fixes #10032. This warning is not necessary anymore since you can resume the onboarding from any step and even easily reset the card if needed.

@bitgamma bitgamma requested a review from churik as a code owner June 28, 2021 12:56
@bitgamma bitgamma self-assigned this Jun 28, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Jun 28, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 99df213 #1 2021-06-28 13:07:29 ~10 min android 📦apk 📲
✔️ 99df213 #1 2021-06-28 13:12:32 ~16 min android-e2e 📦apk 📲
✔️ 99df213 #1 2021-06-28 13:14:42 ~18 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e4bbfe7 #2 2021-06-29 09:23:23 ~11 min android 📦apk 📲
✔️ e4bbfe7 #2 2021-06-29 09:25:06 ~13 min android-e2e 📦apk 📲
✔️ e4bbfe7 #2 2021-06-29 09:28:13 ~16 min ios 📦ipa 📲
✔️ 2504e79 #3 2021-06-29 11:59:37 ~17 min android-e2e 📦apk 📲
✔️ 2504e79 #3 2021-06-29 12:00:07 ~17 min android 📦apk 📲
✔️ 2504e79 #3 2021-06-29 12:01:26 ~19 min ios 📦ipa 📲

@status-im-auto
Copy link
Member

89% of end-end tests have passed

Total executed tests: 70
Failed tests: 8
Passed tests: 62

IDs of failed tests: 6251,5395,5360,5309,5379,6263,6249,6290

Failed tests (8)

Click to expand
  • Rerun tests

    • 1. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: **Dapp is opened!**
    Device 1: **Wait 10s for assets in simpledapp**

    Device 1: Button by xpath:`//*[@text="Assets"] | //*[@content-desc="Assets"]` is not found on the screen

    Device sessions

    2. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)

    Device 1: *Find Button by accessibility id:* `next-page-button`
    Device 1: *Tap on found Button*

    Device 1: Button by xpath: `//*[contains(@text, "Свободный контент")]` is not found on the screen

    Device sessions

    3. test_unread_messages_counter_public_chat, id: 5360

    Device 2: **Signed in successfully!**
    Device 2: **Looking for chat '#pmrpqtb'**

    Counter is not shown for mention in public chat

    Device sessions

    4. test_request_stt_from_daap, id: 5309

    Device 1: *Find WalletButton by xpath:* `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: *Waiting 400s for STT updated balance*

    Device 1: Balance STT 5397000.0 is not changed during 400 seconds!

    Device sessions

    5. test_home_view, id: 5379

    Device 1: *Scrolling down to LogoutButton*
    Device 1: **Sign in (password:qwerty, keycard:False)**

    Device 1: MultiAccountOnLoginButton by xpath:`(//*[@content-desc='chat-icon'])[1]/..` is not found on the screen

    Device sessions

    6. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found AirplaneModeButton*
    Device 2: *Wait for text element TransactionStatus to be equal to Confirmed*

    Device 2: 'Pending' is not equal to expected 'Confirmed' in 60 sec

    Device sessions

    7. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Find WalletButton by xpath:* `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: *Waiting 400s for STT updated balance*

    Device 1: Balance STT 5398000.0 is not changed during 400 seconds!

    Device sessions

    8. test_keycard_fetching_balance_after_offline, id: 6290

    Transaction #5, amount is 4.581e-15
    {'blockNumber': '10527617', 'timeStamp': '1624864981', 'hash': '0x9936fee3e6c01a14750e9e4dc5299a124b1d91bf66c5ec34168c597b89ecb1d9', 'nonce': '4084', 'blockHash': '0xedc4c7e3a88ea39b0d51ba1fe213ccfe15289a9ae9d1ddcd501271ed5d6cdb6a', 'from': '0x061fae3dd75beab5855f584837ca0c0a8e84f5c1', 'contractAddress': '0xe639e24346d646e927f323558e6e0031bfc93581', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'value': '4581', 'tokenName': 'Adi Test Token', 'tokenSymbol': 'ADI', 'tokenDecimal': '7', 'transactionIndex': '1', 'gas': '41235', 'gasPrice': '31000000000', 'gasUsed': '34363', 'cumulativeGasUsed': '75799', 'input': 'deprecated', 'confirmations': '2096'}

    Transaction with amount 0.0028135537 is not found in list of token transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D during 300s

    Device sessions

    Passed tests (62)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    20. test_block_user_from_public_chat, id: 5786
    Device sessions

    21. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    25. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    26. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    27. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    28. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    29. test_long_press_to_delete_chat, id: 5319
    Device sessions

    30. test_copy_and_paste_messages, id: 5317
    Device sessions

    31. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    32. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    33. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    34. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    35. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    36. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    37. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    38. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    39. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    40. test_manage_assets, id: 5341
    Device sessions

    41. test_browser_managing_bookmarks, id: 6633
    Device sessions

    42. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    43. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    44. test_dapps_permissions, id: 5738
    Device sessions

    45. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    46. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    47. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    48. test_wallet_set_up, id: 5335
    Device sessions

    49. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    50. test_can_add_existing_ens, id: 5502
    Device sessions

    51. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    52. test_set_profile_picture, id: 6646
    Device sessions

    53. test_collectible_from_wallet, id: 5346
    Device sessions

    54. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    55. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    56. test_pass_phrase_validation, id: 5363
    Device sessions

    57. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    58. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    59. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    60. test_fetching_balance_after_offline, id: 6237
    Device sessions

    61. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    62. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @bitgamma
    Copy link
    Member Author

    @churik I don't think the e2e to test are related to the PR. Also since it is just removing a warning I don't think additional test is needed. Do you think this can be merged?

    @status-im-auto
    Copy link
    Member

    50% of end-end tests have passed

    Total executed tests: 8
Failed tests: 4
Passed tests: 4

    IDs of failed tests: 6249,5309,6263,6251

    Failed tests (4)

    Click to expand
  • Rerun tests

    • 1. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Find WalletButton by xpath:* `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: *Waiting 400s for STT updated balance*

    Device 1: Balance STT 5401000.0 is not changed during 400 seconds!

    Device sessions

    2. test_request_stt_from_daap, id: 5309

    Device 1: *Find WalletButton by xpath:* `//*[contains(@content-desc,'tab, 3 out of 5')]`
    Device 1: *Waiting 400s for STT updated balance*

    Device 1: Balance STT 5401000.0 is not changed during 400 seconds!

    Device sessions

    3. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found AirplaneModeButton*
    Device 2: *Wait for text element TransactionStatus to be equal to Confirmed*

    Device 2: 'Pending' is not equal to expected 'Confirmed' in 60 sec

    Device sessions

    4. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen

    Device sessions

    Passed tests (4)

    Click to expand

    1. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    2. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    3. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395
    Device sessions

    4. test_home_view, id: 5379
    Device sessions

    @status-im-auto
    Copy link
    Member

    50% of end-end tests have passed

    Total executed tests: 2
Failed tests: 1
Passed tests: 1

    IDs of failed tests: 5742

    Failed tests (1)

    Click to expand
  • Rerun tests

    • 1. test_keycard_interruption_creating_onboarding_flow, id: 5742

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//*[@text='YES' or @text='GOT IT']`

    Device 1: Button by xpath: `//*[@text='YES' or @text='GOT IT']` is not found on the screen

    Device sessions

    Passed tests (1)

    Click to expand

    1. test_keycard_interruption_access_key_onboarding_flow, id: 6246
    Device sessions

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 1
Failed tests: 1
Passed tests: 0

    IDs of failed tests: 5742

    Failed tests (1)

    Click to expand
  • Rerun tests

    • 1. test_keycard_interruption_creating_onboarding_flow, id: 5742

    Device 1: *Find Button by xpath:* `//*[@text="Cancel" or @text="CANCEL"]`
    Device 1: *Tap on found Button*

    Device 1: No Dangerous operation popup is shown on canceling operation from PIN code stage

    Device sessions

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 1
Failed tests: 0
Passed tests: 1

    Passed tests (1)

    Click to expand

    1. test_keycard_interruption_creating_onboarding_flow, id: 5742
    Device sessions

    @churik
    Copy link
    Member

    churik commented Jun 29, 2021

    Good to merge :)
    Please, mind my commit while suashing

    @bitgamma @churik
    remove cancel warning on Keycard onboarding
    6598ef3 
    Co-authored-by: Tetiana Churikova <tatiana@status.im>
Signed-off-by: Michele Balistreri <michele@bitgamma.com>
    @bitgamma bitgamma merged commit 6598ef3 into develop Jun 29, 2021
    @bitgamma bitgamma deleted the fix/10032 branch June 29, 2021 11:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @churik churik churik approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @bitgamma bitgamma

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    in onboarding, when user defines the keycard PIN passcode, he's proposed a 'cancel button'
    4 participants
    @bitgamma @status-im-auto @churik @flexsurfer