Use built-in PBKDF2 implementation #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicio
reviewed
Jul 18, 2022
prichodko
commented
Jul 19, 2022
packages/status-js/vite.config.ts
Outdated
| @@ -4,12 +4,28 @@ import { defineConfig } from 'vite' | |||
|
|
|||
| import { dependencies } from './package.json' | |||
|
|
|||
| import type { Alias } from 'vite' | |||
|
|
|||
| const isTest = process.env.NODE_ENV === 'test' | |||
There was a problem hiding this comment.
I would do it the same, but I remember reading this from their docs:
Use process.env.VITEST or mode property on defineConfig (will be set to test if not overridden) to conditionally apply different configuration in vite.config.ts
@prichodko I don't have the video recording, but at the beginning I took the following perf recording: Before using
After:
Let me know if you'd like the exports of those perf recording too. |
felicio
added a commit
to felicio/status-web
that referenced
this pull request
May 15, 2023
* add pbkdf2 browser implementation * use webcrypto in pbkdf2 * rename pbkdf2 file * use pbkdf2 * add changeset * revert rename * remove browser field from package.json * use `resolve.alias` for pbkdf2 if test * use `mode` in vite.config.ts Co-authored-by: Felicio Mununga <felicio@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBKDF2 is used for generating symmetric keys for the community and every chat for the community.
In a community with ~25 chats, the generation of keys using the PBKDF2 vanilla implementation from ethereum-cryptography took ~10-50 seconds. After migrating for built-in browser implementation it now only takes ~1 second and utilizes multiple threads.
See @felicio's comment for detailed comparison.