Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move global/base styles and remove styled-components #314

Merged
merged 24 commits into from
Oct 5, 2022
Merged

Move global/base styles and remove styled-components #314

merged 24 commits into from
Oct 5, 2022

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Oct 3, 2022

No description provided.

@felicio felicio changed the title Draft: Move global styles and remove styled-components Move global styles and remove styled-components Oct 5, 2022
@felicio felicio marked this pull request as ready for review October 5, 2022 01:49
@felicio felicio requested a review from prichodko October 5, 2022 01:49
@felicio felicio changed the title Move global styles and remove styled-components Move global/base styles and remove styled-components Oct 5, 2022
prichodko
prichodko approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@prichodko prichodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. That's 33.4kB shaved!

packages/status-react/src/routes/index.tsx Outdated Show resolved Hide resolved
packages/status-react/src/styles/config.tsx Show resolved Hide resolved
packages/status-react/src/styles/config.tsx Outdated Show resolved Hide resolved
packages/status-react/src/routes/index.tsx Outdated Show resolved Hide resolved
This was linked to issues Oct 5, 2022
Reset CSS locally #245
Closed
Use CSS variables for theming #239
Closed
@felicio felicio requested a review from prichodko October 5, 2022 11:44
@prichodko
Copy link
Collaborator

For future reference https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM.

@felicio felicio merged commit 05b7306 into status-im:main Oct 5, 2022
felicio added a commit to felicio/status-web that referenced this pull request May 15, 2023
@felicio
Move global/base styles and remove styled-components (status-im#314)
2b71b49
@felicio felicio self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prichodko prichodko prichodko approved these changes

Assignees

@felicio felicio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset CSS locally Use CSS variables for theming
2 participants
@felicio @prichodko