Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmented Control #591

Merged
merged 14 commits into from
Oct 17, 2024
Merged

Segmented Control #591

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ea1129c
f: adds segmented control
marcelines Oct 4, 2024
711e413
f: fix story and adds type variant
marcelines Oct 4, 2024
8c3b156
f: change size type to string
marcelines Oct 4, 2024
c2b695a
f
marcelines Oct 7, 2024
75548bb
f: changeset
marcelines Oct 7, 2024
ea8fda7
f
marcelines Oct 7, 2024
922cd66
f
marcelines Oct 7, 2024
caeb354
f: adds all variants in story and fixes some issues
marcelines Oct 8, 2024
c471e5a
f: use toogle group approach
marcelines Oct 10, 2024
42cb834
f: changes from review
marcelines Oct 10, 2024
a4476bb
add context consumer to tabs
prichodko Oct 16, 2024
e4e2372
cleanup
prichodko Oct 16, 2024
c99d7d9
rename
prichodko Oct 17, 2024
34855e1
simplify stories
prichodko Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/components/src/tabs/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ type RootProps = React.ComponentProps<typeof Tabs.Root> & {

const TabsContext = createContext<Pick<RootProps, 'size' | 'variant'>>({})

function useTabsContext() {
const context = useContext(TabsContext)

if (!context) {
throw new Error('useTabsContext must be used within a <Tabs.Root />')
}

return context
}

export const Root = (props: RootProps) => {
const { size = '32', variant = 'grey', ...rootProps } = props

Expand All @@ -42,7 +52,7 @@ export const List = forwardRef<
React.ElementRef<typeof Tabs.List>,
React.ComponentPropsWithoutRef<typeof Tabs.List>
>((props, ref) => {
const { size } = useContext(TabsContext)!
const { size } = useTabsContext()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦


return (
<Tabs.List
Expand Down Expand Up @@ -74,7 +84,7 @@ export const Trigger = forwardRef<
>((props, ref) => {
const { children, ...rest } = props

const { size, variant } = useContext(TabsContext)!
const { size, variant } = useTabsContext()

return (
<Tabs.Trigger {...rest} ref={ref} className={tabStyles({ variant, size })}>
Expand Down