snapshot: Include hostname in commit message #63
Conversation
drothlis
force-pushed
the
snapshot-hostname
branch
2 times, most recently
from
dd1298c
to
c45d343
Compare
|
@wmanley do you think |
stbt_rig.py
Outdated
| if "CI" in os.environ: | ||
| return "CI" |
There was a problem hiding this comment.
What's the thinking here?
If we're reporting hostname we should just report hostname. We could separately report whether "CI" is in os.environ as necessary.
There was a problem hiding this comment.
That's just for the stbt-rig unit tests to pass. But now I realise CI is probably going to be set in many real-world uses of stbt_rig.py.
|
Longer term I'd like to take this in another direction - snapshot being a long running process including watching the filesystem - and the snapshot on the portal only existing while that process is running. This would enable responding to changes like switching branch or saving pngs. We could also enable two way communication with the portal - pulling when we make edits on the portal. But I've got no current plans to work on this. |
So that the Portal can show a description such as "@user's uncommitted changes on {hostname}". Note: Hostname of GitHub Actions runners are like "fv-az1500-136" (ubuntu) or "Mac-1709811484995.local" (macos).
drothlis
force-pushed
the
snapshot-hostname
branch
from
c45d343
to
ccbff9c
Compare
So that the Portal can show a description such as "@user's uncommitted changes on {hostname}".