Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis-ci not correctly report test result #46

Closed
reverbc opened this issue Jul 31, 2017 · 1 comment
Closed

travis-ci not correctly report test result #46

reverbc opened this issue Jul 31, 2017 · 1 comment

Comments

@reverbc
Copy link
Contributor

reverbc commented Jul 31, 2017

Travis-CI is saying build:passing at the moment, but actually it's not: https://travis-ci.org/stchris/untangle/jobs/255641301

There's two issues with current setting:

  1. the tests were running in ALL the python environments (from py26 to pypy) with tox in ALL travis-ci platform (should be one python environment with one platform)
  2. in setup.py the tests were executed with the following commands:
    os.system('tox')
    sys.exit()
    and the second line will make the test error code not being reported to invoker (in this case, the travis-ci).

There will be two PRs to resolve the above issues: the first one will be fixing all current unit test errors (one of them caused by me - sorry!), and the second one will fix the CI configuration. Please consider accept and merge them in order to prevent travis-ci disallow PR due to test failure. Thanks.

This was referenced Jul 31, 2017
@stchris
Copy link
Owner

stchris commented Jul 1, 2022

Closed after #82

@stchris stchris closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants