Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittest #47

Closed
wants to merge 2 commits into from
Closed

Fix unittest #47

wants to merge 2 commits into from

Conversation

reverbc
Copy link
Contributor

@reverbc reverbc commented Jul 31, 2017

This PR is addressed to the issues describe in #46

For test_python_keyword case: some of the keywords are Python 3 only (e.g. None) and will cause failure in Py26 and Py27. In this case I've added a few more test cases and use six to distinguish them.

For test_invalid_feature and test_invalid_external_dtd cases: using assertRaises as context manager is a feature in Py27 so not compatible with Py26. Switching back to old-school syntax here for backward compatibility.

@coveralls
Copy link

coveralls commented Jul 31, 2017

Coverage Status

Coverage remained the same at 35.514% when pulling 2f78297 on reverbc:fix-unittest into a18c171 on stchris:master.

@stchris
Copy link
Owner

stchris commented Jul 1, 2022

Closing this after #82

@stchris stchris closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants