Optional xml.sax features #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After initializing an xml.sax.parser, optionally set feature values on it before
parsing content.
For example, to turn off the loading of external DTDs, call
untangle.parse(thing, feature_external_ges=False)
References including lists of features:
- https://docs.python.org/2/library/xml.sax.handler.html
- https://docs.python.org/3/library/xml.sax.handler.html
|
Is this likely to be merged? |
|
I'm sorry, I didn't find any time recently to work on untangle. I want to make a new release soon and I'll definitely look at your PR as well. |
|
LGTM! I'll add an example to the docs and I hope to release a new version soon. Thanks for the PR! 👍 |
stchris
added a commit
that referenced
this pull request
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
untangleto parse XML files and it's great. However, I'm operating offline, and by defaultxml.saxtries to load external entities such as DTDs. Loading external entities is a controllable parser "feature."This PR adds the ability to pass
xml.saxparser features as extra arguments toparse(), so for examplebecomes
parse()raisesAttributeErrorif a nonexistent feature is requested.