Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding trailing underscore for python keywords #43

Merged
merged 1 commit into from
Jul 16, 2017
Merged

adding trailing underscore for python keywords #43

merged 1 commit into from
Jul 16, 2017

Conversation

reverbc
Copy link
Contributor

@reverbc reverbc commented Jun 9, 2017

This PR is intended to resolve #42 by adding a trailing _ to children name.

@coveralls
Copy link

coveralls commented Jun 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 35.238% when pulling e015c46 on reverbc:handle-keywords into 2119763 on stchris:master.

@reverbc reverbc mentioned this pull request Jun 9, 2017
Open
@stchris stchris merged commit efd0b48 into stchris:master Jul 16, 2017
@stchris
Copy link
Owner

stchris commented Jul 16, 2017

LGTM! I'll add support for aliases with 2.0.0

stchris added a commit that referenced this pull request Jul 16, 2017
@stchris
Added changelog entry for #43
39a05da
@reverbc reverbc deleted the handle-keywords branch July 17, 2017 21:00
@stchris stchris mentioned this pull request Jul 1, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If an XML tag is a Python keyword SyntaxError is raised on access
3 participants
@reverbc @coveralls @stchris