refactor: use macro for creating doubles

stdlib-js · Apr 18, 2024 · 081d2fe · 081d2fe
1 parent d52893b
commit 081d2fe
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/lib/node_modules/@stdlib/blas/base/sdot/manifest.json b/lib/node_modules/@stdlib/blas/base/sdot/manifest.json
@@ -47,7 +47,8 @@
         "@stdlib/napi/export",
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
-        "@stdlib/napi/argv-strided-float32array"
+        "@stdlib/napi/argv-strided-float32array",
+        "@stdlib/napi/create-double"
       ]
     },
     {
@@ -101,7 +102,8 @@
         "@stdlib/napi/export",
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
-        "@stdlib/napi/argv-strided-float32array"
+        "@stdlib/napi/argv-strided-float32array",
+        "@stdlib/napi/create-double"
       ]
     },
     {
@@ -160,7 +162,8 @@
         "@stdlib/napi/export",
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
-        "@stdlib/napi/argv-strided-float32array"
+        "@stdlib/napi/argv-strided-float32array",
+        "@stdlib/napi/create-double"
       ]
     },
     {
@@ -213,7 +216,8 @@
         "@stdlib/napi/export",
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
-        "@stdlib/napi/argv-strided-float32array"
+        "@stdlib/napi/argv-strided-float32array",
+        "@stdlib/napi/create-double"
       ]
     },
     {
@@ -271,7 +275,8 @@
         "@stdlib/napi/export",
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
-        "@stdlib/napi/argv-strided-float32array"
+        "@stdlib/napi/argv-strided-float32array",
+        "@stdlib/napi/create-double"
       ]
     },
     {
@@ -328,7 +333,8 @@
         "@stdlib/napi/export",
         "@stdlib/napi/argv",
         "@stdlib/napi/argv-int64",
-        "@stdlib/napi/argv-strided-float32array"
+        "@stdlib/napi/argv-strided-float32array",
+        "@stdlib/napi/create-double"
       ]
     },
     {

diff --git a/lib/node_modules/@stdlib/blas/base/sdot/src/addon.c b/lib/node_modules/@stdlib/blas/base/sdot/src/addon.c
@@ -21,8 +21,8 @@
 #include "stdlib/napi/argv.h"
 #include "stdlib/napi/argv_int64.h"
 #include "stdlib/napi/argv_strided_float32array.h"
+#include "stdlib/napi/create_double.h"
 #include <node_api.h>
-#include <assert.h>
 
 /**
 * Receives JavaScript callback invocation data.
@@ -39,11 +39,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
 	STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 4 );
 	STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 1 );
 	STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 3 );
-
-	napi_value v;
-	napi_status status = napi_create_double( env, (double)c_sdot( N, X, strideX, Y, strideY ), &v );
-	assert( status == napi_ok );
-
+	STDLIB_NAPI_CREATE_DOUBLE( env, (double)c_sdot( N, X, strideX, Y, strideY ), v );
 	return v;
 }