Skip to content

Commit

Permalink
chore: stuff from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
aayush0325 committed Oct 18, 2024
1 parent bf66332 commit 4db54d0
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,15 @@
* // returns ~60.0
*
* @example
* var v = acosdf( Math.sqrt( 2 ) / 2 );
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
*
* var v = acosdf( sqrtf( 2 ) / 2 );
* // returns ~45.0
*
* @example
* var v = acosdf( Math.sqrt( 3 ) / 2 );
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
*
* var v = acosdf( sqrtf( 3 ) / 2 );
* // returns ~30.0
*
* @example
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,19 @@
* @module @stdlib/math/base/special/acosdf
*
* @example
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
* var acosdf = require( '@stdlib/math/base/special/acosdf' );
*
* var v = acosdf( 0.0 );
* // returns 90.0
*
* var v = acosdd( 0.5 );
* var v = acosdf( 0.5 );
* // returns ~60.0
*
* var v = acosdf( Math.sqrt( 2 ) / 2 );
* var v = acosdf( sqrtf( 2 ) / 2 );
* // returns ~45.0
*
* var v = acosdf( Math.sqrt( 3 ) / 2 );
* var v = acosdf( sqrtf( 3 ) / 2 );
* // returns ~30.0
*
* var v = acosdf( NaN );
Expand Down
8 changes: 6 additions & 2 deletions lib/node_modules/@stdlib/math/base/special/acosdf/lib/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,15 @@ var acosf = require( '@stdlib/math/base/special/acosf' );
* // returns ~60.0
*
* @example
* var v = acosdf( Math.sqrt( 2 ) / 2 );
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
*
* var v = acosdf( sqrtf( 2 ) / 2 );
* // returns ~45.0
*
* @example
* var v = acosdf( Math.sqrt( 3 ) / 2 );
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
*
* var v = acosdf( sqrtf( 3 ) / 2 );
* // returns ~30.0
*
* @example
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,15 @@ var addon = require( './../src/addon.node' );
* // returns ~60.0
*
* @example
* var v = acosdf( Math.sqrt( 2 ) / 2 );
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
*
* var v = acosdf( sqrtf( 2 ) / 2 );
* // returns ~45.0
*
* @example
* var v = acosdf( Math.sqrt( 3 ) / 2 );
* var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
*
* var v = acosdf( sqrtf( 3 ) / 2 );
* // returns ~30.0
*
* @example
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ tape( 'the function returns `NaN` if provided a value less than `-1`', function
var i;

for ( i = 0; i < 1e3; i++ ) {
v = -(randu()*1.0e6) - (1.0-EPS);
v = -( randu() * 1.0e6 ) - ( 1.0 - EPS );
t.equal( isnanf( acosdf( v ) ), true, 'returns NaN when provided '+v );
}
t.end();
Expand All @@ -112,7 +112,7 @@ tape( 'the function returns `NaN` if provided a value greater than `+1`', functi
var i;

for ( i = 0; i < 1e3; i++ ) {
v = (randu()*1.0e6) + 1.0 + EPS;
v = ( randu() * 1.0e6 ) + 1.0 + EPS;
t.equal( isnanf( acosdf( v ) ), true, 'returns NaN when provided '+v );
}
t.end();
Expand Down

0 comments on commit 4db54d0

Please sign in to comment.