Skip to content

Commit

Permalink
chore: apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
  • Loading branch information
Pranavchiku authored Mar 17, 2024
1 parent 0cf457b commit 74fd7e0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 39 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
bool = isComposite( i + 1 );
if ( typeof bool !== 'boolean' ) {
if ( !isBoolean( bool ) ) {
b.fail( 'should return a boolean' );
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"options": {
"task": "build"
},
"options": {},
"fields": [
{
"field": "src",
Expand All @@ -26,39 +24,6 @@
],
"confs": [
{
"task": "build",
"src": [
"./src/main.c"
],
"include": [
"./include"
],
"libraries": [],
"libpath": [],
"dependencies": [
"@stdlib/math/base/assert/is-prime",
"@stdlib/math/base/assert/is-integer",
"@stdlib/constants/float64/pinf"
]
},
{
"task": "benchmark",
"src": [
"./src/main.c"
],
"include": [
"./include"
],
"libraries": [],
"libpath": [],
"dependencies": [
"@stdlib/math/base/assert/is-prime",
"@stdlib/math/base/assert/is-integer",
"@stdlib/constants/float64/pinf"
]
},
{
"task": "examples",
"src": [
"./src/main.c"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
#include "stdlib/math/base/assert/is_prime.h"
#include "stdlib/math/base/assert/is_integer.h"
#include "stdlib/constants/float64/pinf.h"
#include <stdint.h>
#include <math.h>

/**
* Returns a boolean indicating whether a number is a composite.
Expand Down

0 comments on commit 74fd7e0

Please sign in to comment.