Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Signed-off-by: Athan <kgryte@gmail.com>
  • Loading branch information
kgryte authored Oct 11, 2024
1 parent 457b8f0 commit e87b0be
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' );
*
* @param {PositiveInteger} N - number of indexed elements
* @param {Float64Array} x - input array
* @param {integer} strideX - indexing increment
* @param {integer} strideX - index increment
* @param {NonNegativeInteger} offsetX - starting index
* @returns {number} sum
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var addon = require( './../src/addon.node' );
*
* @param {PositiveInteger} N - number of indexed elements
* @param {Float64Array} x - input array
* @param {integer} strideX - indexing increment
* @param {integer} strideX - index increment
* @param {NonNegativeInteger} offsetX - starting index
* @returns {number} sum
*
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/dnansumors/src/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
* limitations under the License.
*/

#include "stdlib/strided/base/stride2offset.h"
#include "stdlib/blas/ext/base/dnansumors.h"
#include "stdlib/strided/base/stride2offset.h"
#include "stdlib/math/base/assert/is_nan.h"
#include "stdlib/blas/base/shared.h"

Expand Down Expand Up @@ -48,11 +48,11 @@ double API_SUFFIX(stdlib_strided_dnansumors_ndarray)( const CBLAS_INT N, const d
CBLAS_INT ix;
CBLAS_INT i;

ix = offsetX;
sum = 0.0;
if ( N <= 0 ) {
return sum;
}
ix = offsetX;
if ( strideX == 0 ) {
if ( stdlib_base_is_nan( X[ ix ] ) ) {
return sum;
Expand Down

0 comments on commit e87b0be

Please sign in to comment.