Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add C implementation for @stdlib/math/base/special/fast/uint32-sqrt #1932

Closed
3 tasks done
Rejoan-Sardar opened this issue Mar 17, 2024 · 4 comments · Fixed by #1960
Closed
3 tasks done

[RFC]: add C implementation for @stdlib/math/base/special/fast/uint32-sqrt #1932

Rejoan-Sardar opened this issue Mar 17, 2024 · 4 comments · Fixed by #1960
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.

Comments

@Rejoan-Sardar
Copy link
Contributor

Rejoan-Sardar commented Mar 17, 2024 •
edited
Loading

Description

This RFC proposes add C implementation for @stdlib/math/base/special/fast/uint32-sqrt

  uint32_t stdlib_base_fast_uint32_sqrt( uint32_t  x );

Related Issues

Related issues #1917 .

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku
Copy link
Member

Hey @Rejoan-Sardar I will recommend you to first let https://github.com/stdlib-js/stdlib/pulls/Rejoan-Sardar merged. Let this be open and others may work on it. Thank you :)

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Accepted RFC feature request which has been accepted. labels Mar 17, 2024
@Pranavchiku
Copy link
Member

can you please populate issue description with proper C API and documentation?

@Rejoan-Sardar
Copy link
Contributor Author

Hey @Rejoan-Sardar I will recommend you to first let https://github.com/stdlib-js/stdlib/pulls/Rejoan-Sardar merged. Let this be open and others may work on it. Thank you :)

Hey @Pranavchiku I have addressed all the issues and some issues needs review.

@kgryte kgryte added Needs Discussion Needs further discussion. and removed Accepted RFC feature request which has been accepted. labels Mar 17, 2024
@kgryte kgryte closed this as completed Mar 17, 2024
@kgryte kgryte reopened this Mar 17, 2024
@kgryte kgryte added Accepted RFC feature request which has been accepted. and removed Needs Discussion Needs further discussion. labels Mar 17, 2024
This was referenced Mar 17, 2024
Closed
Closed
@gunjjoshi
Copy link
Member

Hey @Rejoan-Sardar, are you still working on this one ?

@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 19, 2024
Merged
1 task
This was referenced Mar 24, 2024
Merged
Closed
Planeshifter pushed a commit that referenced this issue Mar 24, 2024
@Rejoan-Sardar
feat: add C implementation for math/base/special/fast/uint32-sqrt
8a01cf7 
PR-URL: #1960 
Closes: #1932

---------

Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Rejoan-Sardar Rejoan-Sardar mentioned this issue Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/fast/uint32-sqrt
4 participants
@kgryte @gunjjoshi @Pranavchiku @Rejoan-Sardar