Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add C implementation for @stdlib/math/base/special/spence #894

Closed
3 tasks done
Pranavchiku opened this issue Feb 13, 2023 · 9 comments · Fixed by #2298
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/spence #894

Pranavchiku opened this issue Feb 13, 2023 · 9 comments · Fixed by #2298
Labels
Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Pranavchiku commented Feb 13, 2023 •
edited
Loading

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/spence.

double stdlib_base_spence( const double x );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. RFC Request for comments. Feature requests and proposed changes. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Feb 13, 2023
@Jordan-Gallivan
Copy link
Contributor

I'd like to take this one on as well.

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023

Thanks, @Jordan-Gallivan, that would be great!

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023 •
edited
Loading

@Jordan-Gallivan This implementation will be a touch more involved than your previous contributions.

You can use asin, as a reference. Namely, it will involve autogenerating some polynomial expressions, which requires a special comment syntax and running a script. However, instead of evalrational, you'll need to update evalpoly. You can consult other special math functions which have a C implementation and an evalpoly script.

Let us know if you have questions!

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023

Also, I'm happy to hop on a Google Meet to discuss further.

@Jordan-Gallivan
Copy link
Contributor

Jordan-Gallivan commented Feb 28, 2023 •
edited
Loading

@kgryte I definitely might need more coaching than the previous implementations but I think I'm up to the task. I'll comb through everything tonight and let you know if I have any questions before I jump in, in which case I'll definitely take you up on the Google Meet offer.

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023

Sounds good! Thanks for taking the initiative and working on this!

@Jordan-Gallivan
Copy link
Contributor

@kgryte wanted to drop you a line and let you know that I'm still down to work this problem, I just got slammed last week with school/the internship search.

@kgryte
Copy link
Member

kgryte commented Mar 5, 2023

@Jordan-Gallivan No worries!

@Jordan-Gallivan Jordan-Gallivan mentioned this issue Mar 7, 2023
Closed
@Jordan-Gallivan
Copy link
Contributor

@kgryte just submitted a PR. You weren't kidding, this was a doozie. I added a few questions in the PR so please lemme know what I can fix.

@gunjjoshi gunjjoshi mentioned this issue Jun 3, 2024
Merged
1 task
kgryte added a commit that referenced this issue Jun 7, 2024
@gunjjoshi @kgryte @Planeshifter
feat: add C implementation for math/base/special/spence
e382574 
PR-URL: #2298
Closes: #894
Closes: #968
Ref: #649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@gunjjoshi @kgryte
@Planeshifter @aman-095
feat: add C implementation for math/base/special/spence
4170375 
PR-URL: stdlib-js#2298
Closes: stdlib-js#894
Closes: stdlib-js#968
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
3 participants
@kgryte @Pranavchiku @Jordan-Gallivan