-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add next-code-point-index string package #1117
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/string/next-code-point-index/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/test/fixtures/stdin_error.js.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steff456 Thanks for working on this. There are a few discrepancies among return values. And I left a question regarding what should happen for unpaired surrogates.
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/lib/main.js
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/string/next-code-point-index/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/next-code-point-index/test/test.js
Outdated
Show resolved
Hide resolved
out = nextCodePointIndex( '𐒻𐓟𐒻𐓟', 1 ); | ||
t.strictEqual( out, 3, 'returns expected value' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out = nextCodePointIndex( '𐒻𐓟𐒻𐓟', 1 ); | |
t.strictEqual( out, 3, 'returns expected value' ); | |
out = nextCodePointIndex( '𐒻𐓟𐒻𐓟', 0 ); | |
t.strictEqual( out, 2, 'returns expected value' ); |
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Part of #1062
Description
This pull request:
@stdlib/string/next-code-point-index
Related Issues
This pull request:
Part of #1062
Questions
No.
Other
This PR depends on the package
@stdlib/string/num-code-points
available in #1097Checklist
@stdlib-js/reviewers