feat : add @stdlib/assert/is-nonnegative-finite

[marsian83]

Resolves #1344 .

Description

This PR adds the package @stdlib/assert/is-nonnegative-finite.

The package implements assertion for nonnegative number except positive infinity.

Alias: isNonNegativeFinite

Related Issues

• resolves [RFC]: add @stdlib/assert/is-nonnegative-finite #1344

Questions

I have used the @stdlib/asset/is-finite in order to achieve the desired result. Is this considered good practice, what are the guidelines for using internal packages, when and where is it ideal.

Checklist

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[Planeshifter]

@marsian83

I have used the @stdlib/asset/is-finite in order to achieve the desired result. Is this considered good practice, what are the guidelines for using internal packages, when and where is it ideal.

Yes, we generally want to explicitly use internal packages instead of native methods. This makes the dependencies of the packages explicit and what functionality they use. We also have several constructors and functions where we have or are planning to go beyond what the ECMAScript standard stipulates.

The PR looks good and should be ready to merge soon; thanks for your work on this!

Aside: When applying suggestions from code review, it is possible to batch them all into a single commit when doing it from the files tab. That is potentially faster than accepting them and merging them one by one.

[marsian83]

@Planeshifter Hi, apologies, I forgot to correct the licensing dates, I have signed and commited your suggestions.
Also, thanks for letting me know about the internal dependency convention,

[Planeshifter]

@marsian83 Running CI and assuming everything passes, this should be ready to land!

[Planeshifter]

Please have a look at the CI failures; for repl.txt, we want to ensure that we don't exceed 80 characters per line to display nicely in a terminal window. Should add a linebreak there where required.

[marsian83]

Hi, I signed off and commited your messages. Thanks for highlighting what I should keep in mind from next time on.

I had a question though...

// eslint-disable-line stdlib/no-redeclare

I did not understand what this comment is for and where should I use this. googling about this only results in "Disabling an eslint feature" but why and when would we want to do so?

[marsian83]

I just noticed your edit regarding merging commits from the file section.
I will keep that in mind from next time on

[Planeshifter]

@marsian83 Will merge once CI passes.