Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add utils/any-in-by #1411

Merged
merged 3 commits into from
Mar 5, 2024
Merged

feat: add utils/any-in-by #1411

merged 3 commits into from
Mar 5, 2024

Conversation

itsspriyansh
Copy link
Contributor

Resolves #823

Description

What is the purpose of this pull request?

This pull request:

  • a adds utils/any-in-by package
  • b tests whether any "own" and inherited property of a provided object satisfies a predicate function.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@itsspriyansh itsspriyansh mentioned this pull request Feb 28, 2024
Closed
3 tasks
Planeshifter
Planeshifter requested changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Left some comments that will need to be addressed before this can be merged.

lib/node_modules/@stdlib/utils/any-in-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/docs/types/index.d.ts Outdated Show resolved Hide resolved
@Planeshifter Planeshifter added the Needs Changes Pull request which needs changes before being merged. label Mar 2, 2024
@Planeshifter Planeshifter changed the title feat: added @stdlib/utils/any-in-by feat: add utils/any-in-by Mar 3, 2024
@itsspriyansh
Copy link
Contributor Author

@Planeshifter I have resolved all the problems.

Planeshifter
Planeshifter reviewed Mar 3, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming along well, but I noticed we are still missing some tests. Would you be able to please add these?

lib/node_modules/@stdlib/utils/any-in-by/test/test.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/test/test.js Show resolved Hide resolved
lib/node_modules/@stdlib/utils/any-in-by/test/test.js Show resolved Hide resolved
@itsspriyansh
added some more tests
b2cea33 
Signed-off-by: Priyansh <88396544+itsspriyansh@users.noreply.github.com>
@itsspriyansh
added some tests
17211fb 
Signed-off-by: Priyansh <88396544+itsspriyansh@users.noreply.github.com>
@itsspriyansh
Copy link
Contributor Author

@Planeshifter I have fixed the typo and I have added 3 tests where:

  1. predicate is not a function
  2. predicate is not provided
  3. function returns false

Planeshifter
Planeshifter approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution!

@Planeshifter Planeshifter merged commit 69c167d into stdlib-js:develop Mar 5, 2024
7 checks passed
@itsspriyansh itsspriyansh deleted the any-in-by branch March 5, 2024 09:17
utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
@itsspriyansh
feat: add utils/any-in-by
7ec1ab8 
PR-URL: stdlib-js#1411
Closes: stdlib-js#823

---------

Signed-off-by: Priyansh <88396544+itsspriyansh@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/utils/any-in-by
3 participants
@itsspriyansh @Planeshifter @stdlib-bot