Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add complex/parse-float32 #1430

Merged
merged 6 commits into from
Mar 2, 2024
Merged

feat: add complex/parse-float32 #1430

merged 6 commits into from
Mar 2, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

@Rejoan-Sardar Rejoan-Sardar commented Mar 1, 2024

Resolves #1332 .

Description

What is the purpose of this pull request?

This pull request:
Adds the package @stdlib/complex/parse-float32.

Related Issues

Does this pull request have any related issues?

This pull request:

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Tests:
Screenshot 2024-02-29 230900

Benchmarks
Screenshot 2024-02-29 230841

Examples
Screenshot 2024-02-29 230624

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

Rejoan-Sardar and others added 2 commits March 1, 2024 10:58
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

.gitignore Outdated
@@ -1,188 +0,0 @@
#/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please revert this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pranav I reverted this and also What are the changes I have to do, I changed it now please check

@Pranavchiku Pranavchiku added the Needs Changes Pull request which needs changes before being merged. label Mar 1, 2024
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't went much into lib/main.js overall it is good. Requested few changes, once addressed this will be ready to merge.

Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 2, 2024
@Planeshifter Planeshifter merged commit 514d38f into stdlib-js:develop Mar 2, 2024
7 checks passed
@Rejoan-Sardar Rejoan-Sardar deleted the parse-float32 branch March 2, 2024 17:23
utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
PR-URL: stdlib-js#1430
Closes: stdlib-js#1332

---------

Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/complex/parse-float32
4 participants