feat: add C implementation for math/base/special/asec
#1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
changed the title
math/base/special/asec
Pranavchiku
requested changes
Mar 6, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| @license Apache-2.0 | |||
|
|
|||
| Copyright (c) 2022 The Stdlib Authors. | |||
| Copyright (c) 2024 The Stdlib Authors. | |||
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2024 The Stdlib Authors. | |
| Copyright (c) 2022 The Stdlib Authors. |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2022 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 The Stdlib Authors. | |
| * Copyright (c) 2024 The Stdlib Authors. |
lib/node_modules/@stdlib/math/base/special/asec/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/asec/benchmark/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/asec/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function computes the inverse (arc) secant on the interval `[1e300,1e308]`', function test( t ) { |
There was a problem hiding this comment.
Suggested change
| tape( 'the function computes the inverse (arc) secant on the interval `[1e300,1e308]`', function test( t ) { | |
| tape( 'the function computes the inverse (arc) secant on the interval `[1e300,1e308]`', opts, function test( t ) { |
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns `NaN` if provided `NaN`', function test( t ) { |
There was a problem hiding this comment.
Suggested change
| tape( 'the function returns `NaN` if provided `NaN`', function test( t ) { | |
| tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) { |
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns `NaN` if provided `+0`', function test( t ) { |
There was a problem hiding this comment.
Suggested change
| tape( 'the function returns `NaN` if provided `+0`', function test( t ) { | |
| tape( 'the function returns `NaN` if provided `+0`', opts, function test( t ) { |
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns `NaN` if provided `-0`', function test( t ) { |
There was a problem hiding this comment.
Suggested change
| tape( 'the function returns `NaN` if provided `-0`', function test( t ) { | |
| tape( 'the function returns `NaN` if provided `-0`', opts, function test( t ) { |
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function returns `NaN` on the interval `(-1, 1)`', function test( t ) { |
There was a problem hiding this comment.
Suggested change
| tape( 'the function returns `NaN` on the interval `(-1, 1)`', function test( t ) { | |
| tape( 'the function returns `NaN` on the interval `(-1, 1)`', opts, function test( t ) { |
Pranavchiku
added
Feature
|
@Pranavchiku I have addressed all the issues you mentioned in your review. Please take a look at the changes |
@Pranavchiku I have addressed all the issues you mentioned in your review.please check. |
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Mar 9, 2024
This was referenced Mar 17, 2024
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #861 .
Description
This pull request:Add C implementation for @stdlib/math/base/special/asec
Related Issues
This pull request:
@stdlib/math/base/special/asec#861Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers