Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/sdssumpw to follow current project conventions #1740

Merged
merged 4 commits into from
Apr 15, 2024
Merged

refactor: update blas/ext/base/sdssumpw to follow current project conventions #1740

merged 4 commits into from
Apr 15, 2024

Conversation

PraneGIT
Copy link
Contributor

@PraneGIT PraneGIT commented Mar 6, 2024 •
edited by kgryte
Loading

Resolves #1526 .

Description

refactors @stdlib/blas/ext/base/sdssumpw to follow current project conventions.

This pull request:

Related Issues

Does this pull request have any related issues?

No.
This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 6, 2024
@PraneGIT PraneGIT changed the title refactor: update blas/ext/base/sdssumpw to follow current project conventions refactor: update blas/ext/base/sdssumpw to follow current project conventions Mar 6, 2024
@PraneGIT PraneGIT mentioned this pull request Mar 19, 2024
Closed
6 tasks
@kgryte kgryte added the Enhancement Issue or pull request for enhancing existing functionality. label Mar 21, 2024
@PraneGIT
Copy link
Contributor Author

@Planeshifter I have pushed the suggested changes.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 15, 2024
Planeshifter
Planeshifter approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Should be ready to land now after some edits.

@Planeshifter Planeshifter merged commit a5e27be into stdlib-js:develop Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Needs Review A pull request which needs code review. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sdssumpw to follow current project conventions
3 participants
@PraneGIT @Planeshifter @kgryte