Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/cotd #1772

Merged
merged 14 commits into from
Mar 15, 2024
Merged

Conversation

the-r3aper7
Copy link
Contributor

@the-r3aper7 the-r3aper7 commented Mar 8, 2024

Resolves #40

Description

What is the purpose of this pull request?

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add math/base/special/cotd feat: add math/base/special/cotd Mar 8, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
@the-r3aper7
Copy link
Contributor Author

@Planeshifter should I add checks for when input is -180 it should return -Infinity because I saw in julia when passed -180 it is returning -Inf

@the-r3aper7
Copy link
Contributor Author

@Planeshifter this PR is ready for review.

Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small change requests that hopefully will be easy to resolve.

Ready for merging otherwise, I think.

the-r3aper7 and others added 8 commits March 13, 2024 08:06
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
…ex.d.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@the-r3aper7
Copy link
Contributor Author

the-r3aper7 commented Mar 13, 2024

@Planeshifter i have made the changes to this PR and others too. It is ready to be merged 🚀

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the Documentation Improvements, additions, or changes to documentation. label Mar 15, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this one in as well; thanks!

@Planeshifter Planeshifter merged commit c5e01bf into stdlib-js:develop Mar 15, 2024
8 checks passed
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 15, 2024
@the-r3aper7 the-r3aper7 deleted the cotd branch March 15, 2024 02:03
@kgryte kgryte removed the Documentation Improvements, additions, or changes to documentation. label Mar 15, 2024
@kgryte
Copy link
Member

kgryte commented Mar 15, 2024

@the-r3aper7 Same comment. Can you tick the box in the OP indicating that you've read the contributing guidelines? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cotd
4 participants