Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add c implementation for math/base/assert/is-negative-finite #1778

Merged
merged 5 commits into from
Mar 8, 2024
Merged

feat: add c implementation for math/base/assert/is-negative-finite #1778

merged 5 commits into from
Mar 8, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Mar 8, 2024

Description

What is the purpose of this pull request?

This RFC proposes adding native C implementation for @stdlib/math/base/assert/is-negative-finite

bool stdlib_base_is_negative_finite( const double x )

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 8, 2024
Pranavchiku
Pranavchiku requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, once addressed this will be good to merge.

lib/node_modules/@stdlib/math/base/assert/is-negative-finite/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-negative-finite/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-negative-finite/benchmark/benchmark.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-negative-finite/examples/c/example.c Outdated Show resolved Hide resolved
@Pranavchiku
chore: apply suggestions from code review
1add6b7 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
Update lib/node_modules/@stdlib/math/base/assert/is-negative-finite/R…
ed2f4d3 
…EADME.md

Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
Update lib/node_modules/@stdlib/math/base/assert/is-negative-finite/e…
424c992 
…xamples/c/example.c

Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
b0d931f 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @aman-095 !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 8, 2024
@Pranavchiku Pranavchiku changed the title feat: add c implementation for @stdlib/math/base/assert/is-negative-finite feat: add c implementation for math/base/assert/is-negative-finite Mar 8, 2024
@Planeshifter Planeshifter merged commit 3490734 into stdlib-js:develop Mar 8, 2024
7 checks passed
@aman-095 aman-095 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @Pranavchiku @Planeshifter