Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/asind #1781

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Conversation

the-r3aper7
Copy link
Contributor

@the-r3aper7 the-r3aper7 commented Mar 8, 2024

Resolves #35

Description

What is the purpose of this pull request?

This pull request:

  • Adds functionality to compute asind of any given input.
  • Say we have input x, so it should satisfies this x <= 1 or x >= -1 else it will return NaN
input asind
0 0
0.5 30
$\frac{1}{\sqrt{2}}$ 45
$\frac{\sqrt{3}}{2}$ 60
1 90

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add math/base/special/asind feat: add math/base/special/asind Mar 8, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
the-r3aper7 and others added 5 commits March 10, 2024 00:22
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@the-r3aper7
Copy link
Contributor Author

@Planeshifter this PR is ready for review.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Copy link
Member

Thank you; will merge once CI has passed.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
@Planeshifter Planeshifter merged commit 7d855d1 into stdlib-js:develop Mar 12, 2024
7 checks passed
@the-r3aper7 the-r3aper7 deleted the asind branch March 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement asind
2 participants