Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/cscd #1786

Merged
merged 10 commits into from
Mar 12, 2024
Merged

feat: add math/base/special/cscd #1786

merged 10 commits into from
Mar 12, 2024

Conversation

the-r3aper7
Copy link
Contributor

@the-r3aper7 the-r3aper7 commented Mar 8, 2024 •
edited
Loading

Resolves #39

Description

What is the purpose of this pull request?

This pull request:

  • Adds functionality to compute cscd of any input (in degree).
degree secd
0 Infinity
30 2
45 1.414
60 ~1.15
90 1.0

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
the-r3aper7 and others added 2 commits March 9, 2024 22:42
@the-r3aper7
feat: add math/base/special/cscd
ff0b6f8
@the-r3aper7
Update test.js
c978bf6 
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@the-r3aper7 the-r3aper7 changed the title feat: add math/base/special/cscd feat: add math/base/special/cscd Mar 9, 2024
the-r3aper7 and others added 4 commits March 10, 2024 02:00
@the-r3aper7
Update README.md
e9dc81e 
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@the-r3aper7
Update test.js
b0b0c3b 
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@the-r3aper7
Update main.js
dfaa0db 
Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
@the-r3aper7
feat: add math/base/special/cscd
718e6ba
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@Planeshifter
Update lib/node_modules/@stdlib/math/base/special/cscd/lib/main.js
3738505 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/math/base/special/cscd/package.json
5152010 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
@Planeshifter Planeshifter merged commit bb6ac7e into stdlib-js:develop Mar 12, 2024
7 checks passed
@the-r3aper7 the-r3aper7 deleted the cscd branch March 12, 2024 13:44
@the-r3aper7
Copy link
Contributor Author

i have to update 4 more PRs i'll let you know.

@the-r3aper7 the-r3aper7 mentioned this pull request Mar 15, 2024
Closed
5 tasks
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Mar 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement cscd
3 participants
@the-r3aper7 @Planeshifter @stdlib-bot