Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/xlog1py #1847

Merged
merged 3 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/special/xlog1py #1847

merged 3 commits into from
Mar 14, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

Resolves #1842 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/xlog1py

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 12, 2024
@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/special/xlog1py feat: add C implementation for math/base/special/xlog1py Mar 12, 2024
@Pranavchiku
chore: apply suggestions from code review
d498a3d 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything works fine on my machine. This is good to merge. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
@Planeshifter @Pranavchiku
Update lib/node_modules/@stdlib/math/base/special/xlog1py/test/test.n…
12d1e04 
…ative.js

Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit dc84fce into stdlib-js:develop Mar 14, 2024
7 checks passed
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/special/xlog1py
3 participants
@Rejoan-Sardar @Pranavchiku @Planeshifter