Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/scusum to follow current project conventions #1864

Merged
merged 7 commits into from
Mar 21, 2024
Merged

refactor: update blas/ext/base/scusum to follow current project conventions #1864

merged 7 commits into from
Mar 21, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 13, 2024

Resolves #1516 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors @stdlib/blas/ext/base/scusum to follow current projects convention

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 13, 2024

@Pranavchiku, can you review the PR.

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 14, 2024
kgryte
kgryte requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and mark this PR as needing changes, as discussed in #1867. Whatever changes are made there will need to be made in this PR, as well.

@kgryte kgryte changed the title refactor blas/ext/base/scusum to follow current project conventions refactor: update blas/ext/base/scusum to follow current project conventions Mar 14, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 14, 2024
@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 14, 2024

@kgryte, applied all suggestions.

@AuenKr AuenKr mentioned this pull request Mar 15, 2024
Merged
1 task
@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 17, 2024

@kgryte, waiting for review.

@kgryte
Copy link
Member

kgryte commented Mar 18, 2024

@AuenKr Thank you for the ping. Sorry, I've been a bit swapped. I will try and review this within the next day.

@kgryte kgryte self-requested a review March 18, 2024 08:08
kgryte
kgryte requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AuenKr, for working on this. I left a couple of minor comments. I'll leave it to you to resolve, as the comments may apply to other PRs which you may have open making similar changes to strided array interfaces.

@kgryte kgryte mentioned this pull request Mar 19, 2024
Merged
1 task
@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 19, 2024

@kgryte, applied all changes to other PR also.

@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 20, 2024

@kgryte, applied changes.

kgryte
kgryte approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @AuenKr!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 21, 2024
@kgryte kgryte merged commit 5ca58c5 into stdlib-js:develop Mar 21, 2024
8 checks passed
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/scusum to follow current project conventions
2 participants
@AuenKr @kgryte