Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/assert/uint32-is-pow2 #1886

Merged
merged 3 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/assert/uint32-is-pow2 #1886

merged 3 commits into from
Mar 14, 2024

Conversation

performant23
Copy link
Contributor

This commit if applied adds the C implementation to @stdlib/math/base/assert/uint32-is-pow2 package

Description

This pull request:

  • adds the native C implementation to @stdlib/math/base/assert/uint32-is-pow2

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@performant23
feat: add C implementation for math/base/assert/uint32-is-pow2
372a566 
This commit if applied adds the C implementation to @stdlib/math/base/assert/uint32-is-pow2 package
@performant23
Copy link
Contributor Author

performant23 commented Mar 14, 2024 •
edited
Loading

Regarding the naming convention: Since benchmark.js uses the alias, isPow2, it is used in benchmark.native.js and since in test.js it is used as isPow2Uint32, the same alias is used for test.native.js

@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/assert/uint32-is-pow2 feat: add C implementation for math/base/assert/uint32-is-pow2 Mar 14, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 14, 2024
@Pranavchiku
chore: apply suggestions from code review
3608831 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally, thanks @performant23 !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 14, 2024
@Planeshifter
Apply suggestions from code review
d046ae7 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 3d7c806 into stdlib-js:develop Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/assert/uint32-is-pow2
3 participants
@performant23 @Planeshifter @Pranavchiku