Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/sdsapxsum to follow current project conventions #1889

Merged
merged 6 commits into from
Mar 21, 2024
Merged

refactor: update blas/ext/base/sdsapxsum to follow current project conventions #1889

merged 6 commits into from
Mar 21, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 14, 2024

Resolves #1521 .

Description

What is the purpose of this pull request?

This pull request:

  • update @stdlib/blas/ext/base/sdsapxsum to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 15, 2024
@AuenKr AuenKr mentioned this pull request Mar 15, 2024
Merged
1 task
Planeshifter
Planeshifter requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a few changes needed and we can merge your PR. Thanks!

@Planeshifter Planeshifter added the Needs Changes Pull request which needs changes before being merged. label Mar 20, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 20, 2024
@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 20, 2024

@Planeshifter, applied all suggestions.

@kgryte
Apply suggestions from code review
d67045f 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @AuenKr. Need to add the missing dependency in the manifest.json configuration objects, and this should be ready for merge.

@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 21, 2024

@kgryte, added dependency in manifest.json file

Planeshifter
Planeshifter approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@Planeshifter Planeshifter merged commit aebb788 into stdlib-js:develop Mar 21, 2024
8 checks passed
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 22, 2024
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sdsapxsum to follow current project conventions
4 participants
@AuenKr @Planeshifter @kgryte @stdlib-bot