Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/sapxsumkbn to follow current project conventions #1895

Merged
merged 6 commits into from
Mar 22, 2024
Merged

refactor: update blas/ext/base/sapxsumkbn to follow current project conventions #1895

merged 6 commits into from
Mar 22, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 15, 2024

Resolves #1511.

Description

What is the purpose of this pull request?

This pull request:

  • refactored @stdlib/blas/ext/base/sapxsumkbn to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 15, 2024
@AuenKr AuenKr mentioned this pull request Mar 15, 2024
Merged
1 task
@AuenKr AuenKr marked this pull request as draft March 19, 2024 15:17
@Planeshifter Planeshifter self-requested a review March 20, 2024 01:10
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 20, 2024
@AuenKr AuenKr marked this pull request as ready for review March 22, 2024 16:25
@kgryte
Apply suggestions from code review
fcea8f3 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
7cb67bd 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @AuenKr!

@kgryte kgryte merged commit f2b3fbc into stdlib-js:develop Mar 22, 2024
8 checks passed
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter left review comments

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sapxsumkbn to follow current project conventions
4 participants
@AuenKr @Planeshifter @kgryte @stdlib-bot