Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/fast/max #1912

Merged
merged 3 commits into from
Mar 17, 2024
Merged

feat: add C implementation for math/base/special/fast/max #1912

merged 3 commits into from
Mar 17, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

@Rejoan-Sardar Rejoan-Sardar commented Mar 16, 2024 •
edited
Loading

Resolves a part of #649 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/fast/max

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 16, 2024
@Pranavchiku
chore: apply suggestions from code review
7f96ce1 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku Pranavchiku changed the title feat: add C implementation for math/base/special/fast/max feat: add C implementation for math/base/special/fast/max Mar 16, 2024
Pranavchiku
Pranavchiku approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 16, 2024
@gunjjoshi gunjjoshi mentioned this pull request Mar 16, 2024
Closed
14 tasks
@Planeshifter
Apply suggestions from code review
07f4a76 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 67e90ff into stdlib-js:develop Mar 17, 2024
8 checks passed
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rejoan-Sardar @Planeshifter @Pranavchiku @stdlib-bot