refactor: add support for ratios evaluating as infinity in math/base/tools/evalrational-compile-c

[gunjjoshi]

Description

What is the purpose of this pull request?

This pull request:

• Modifies the value2string function in math/base/tools/evalrational-compile-c/lib/main.js to handle the edge case where the ratio is positive or negative infinity. This modification has been done base on feat: add C implementation for math/base/special/gamma-lanczos-sum #1834 (comment).

Related Issues

Does this pull request have any related issues?

• resolves a part of [RFC]: add C implementation for @stdlib/math/base/special/gamma-lanczos-sum #1822.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• ☑️ Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[gunjjoshi]

I have used PINF and NINF to check whether x is infinite, rather than using is-infinite. The reason being, we need to set the string to 1.0 / 0.0 or -1.0 / 0.0 based on the case if the ratio is positive infinity or negative infinity.

Also, I have added 2 tests, which use string.includes() function, to check if the desired infinity value is contained in the generated string or not.

This PR is a pre-requisite for #1834.

[kgryte]

LGTM. Thanks, @gunjjoshi. You'll want to make a note of how I updated the tests. As done elsewhere in the tests, we need to test across all the different function types. In general, unit tests should be agnostic as possible regarding implementation details (i.e., they should test to API and expected behavior, not our knowledge of how things are implemented).

[gunjjoshi]

LGTM. Thanks, @gunjjoshi. You'll want to make a note of how I updated the tests. As done elsewhere in the tests, we need to test across all the different function types. In general, unit tests should be agnostic as possible regarding implementation details (i.e., they should test to API and expected behavior, not our knowledge of how things are implemented).

I will certainly make a note of that, thanks for sharing this !