Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dnannsum to follow current project conventions #2019

Merged
merged 6 commits into from
Apr 15, 2024
Merged

refactor: update blas/ext/base/dnannsum to follow current project conventions #2019

merged 6 commits into from
Apr 15, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 24, 2024

Resolves #1478 .

Description

What is the purpose of this pull request?

This pull request:

  • refactored @stdlib/blas/ext/base/dnannsum to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 24, 2024
@AuenKr AuenKr marked this pull request as draft March 24, 2024 17:56
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 24, 2024
Pranavchiku
Pranavchiku requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks for this PR!

@Pranavchiku Pranavchiku added the Needs Changes Pull request which needs changes before being merged. label Mar 25, 2024
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
@AuenKr AuenKr marked this pull request as ready for review April 7, 2024 20:31
@AuenKr
Copy link
Contributor Author

AuenKr commented Apr 8, 2024

@Pranavchiku applied all suggestion and fixed addon.c file which causing test case to fail.

@Planeshifter
Apply suggestions from code review
cd96f9c 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@AuenKr
Copy link
Contributor Author

AuenKr commented Apr 10, 2024 •
edited
Loading

@Planeshifter can u review the PR?

@Planeshifter Planeshifter self-requested a review April 15, 2024 12:46
Planeshifter
Planeshifter approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AuenKr for your PR! Looked great, I just had to add a missing dependency to the manifest.json example and benchmarks configurations. Will merge shortly.

@Planeshifter Planeshifter merged commit a65a14a into stdlib-js:develop Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnannsum to follow current project conventions
4 participants
@AuenKr @Planeshifter @Pranavchiku @stdlib-bot