Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/idamax #2152

Merged
merged 7 commits into from
Apr 16, 2024
Merged

feat: add blas/base/idamax #2152

merged 7 commits into from
Apr 16, 2024

Conversation

aman-095
Copy link
Member

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to find the index of the first element having maximum absolute value as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/idamax is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 11, 2024
Pranavchiku
Pranavchiku requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments above, I request you to iterate over isamax also.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Fortran Issue involves or relates to Fortran. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Apr 12, 2024
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Apr 16, 2024
kgryte
kgryte approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095! Note that the changes made to this PR should be replicated to the PR adding support for isamax.

@kgryte kgryte merged commit 95653a3 into stdlib-js:develop Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter left review comments

@Pranavchiku Pranavchiku Pranavchiku requested changes

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Fortran Issue involves or relates to Fortran. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aman-095 @Planeshifter @kgryte @Pranavchiku @stdlib-bot