Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update math/base/special/log10 to freeBSD version 12.2.0 #2176

Merged
merged 3 commits into from
Apr 16, 2024
Merged

refactor: update math/base/special/log10 to freeBSD version 12.2.0 #2176

merged 3 commits into from
Apr 16, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 16, 2024

Description

What is the purpose of this pull request?

This pull request:

  • updates existing JavaScript implementation to follow FreeBSD version 12.2.0.
  • adds corresponding test.
  • removed klog.js and related files, instead used kernelLog1p.

Related Issues

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

I have made slight modifications in that part too, which was common in both 9.3.0 and 12.2.0, based on what we have in log2, such as using toWords instead of getHighWord. This is because, after including a separate branch for checking log(1) = +0, our older code was not reaching that branch, though it gave the correct result. This was leading to a code coverage of less than 100%.

After the changes, it does well.

Screenshot 2024-04-16 at 12 02 30

References:

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 16, 2024
gunjjoshi and others added 2 commits April 16, 2024 12:07
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte
Copy link
Member

kgryte commented Apr 16, 2024

Also, thank you for including the reference links in the OP. That is quite useful, especially when looking back at changes and their rationale.

@kgryte kgryte merged commit 65c3b27 into stdlib-js:develop Apr 16, 2024
6 checks passed
@gunjjoshi gunjjoshi deleted the log10 branch June 2, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants