Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lapack/base/dpttrf #2578

Merged
merged 19 commits into from
Jul 28, 2024
Merged

feat: add lapack/base/dpttrf #2578

merged 19 commits into from
Jul 28, 2024

Conversation

Pranavchiku
Copy link
Member

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dpttrf.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label Jul 13, 2024
@Pranavchiku Pranavchiku mentioned this pull request Jul 13, 2024
Open
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jul 14, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jul 14, 2024
@Pranavchiku Pranavchiku marked this pull request as ready for review July 22, 2024 14:51
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 22, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 28, 2024
kgryte
kgryte approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @Pranavchiku.

I did a fair amount of clean-up, especially in tightening up the implementation by reducing the number of arithmetic operations and in adding test cases. For this package, you were light on tests, especially in ensuring that status code return values were handled correctly. You had incorrectly had k be based on the underlying buffer index (e.g., offsetD + (i*strideD)), rather than the view index, which is what would make sense from a user POV and ensures consistent status code values between the two APIs and ensures consistency with the LAPACK docs where info corresponds to the principal minor of order k. Allowing k to exceed N simply doesn't make sense.

@kgryte kgryte merged commit 0630400 into stdlib-js:develop Jul 28, 2024
8 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@Pranavchiku @kgryte @gunjjoshi
feat: add lapack/base/dpttrf
e5cc221 
PR-URL: stdlib-js#2578
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte