Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add boolean dtype support to ndarray/base/assign #2598

Merged
merged 2 commits into from
Jul 14, 2024
Merged

feat: add boolean dtype support to ndarray/base/assign #2598

merged 2 commits into from
Jul 14, 2024

Conversation

Jaysukh-409
Copy link
Member

@Jaysukh-409 Jaysukh-409 commented Jul 14, 2024 •
edited
Loading

Resolves: Subtask of #2547

Description

What is the purpose of this pull request?

This pull request:

  • This PR will add boolean datatype support in ndarray/base/assign.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Jaysukh-409 Jaysukh-409 added the Enhancement Issue or pull request for enhancing existing functionality. label Jul 14, 2024
kgryte
kgryte approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit 6ea880c into stdlib-js:develop Jul 14, 2024
7 checks passed
@kgryte kgryte deleted the ndarray/base/assign branch July 14, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Enhancement Issue or pull request for enhancing existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte