Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests to ndarray/base/nullary #2599

Merged
merged 8 commits into from
Jul 15, 2024
Merged

test: add tests to ndarray/base/nullary #2599

merged 8 commits into from
Jul 15, 2024

Conversation

headlessNode
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • add tests to @stdlib/ndarray/base/nullary/test/test.3d.js for 100% test coverage

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode
Copy link
Contributor Author

@kgryte 100% coverage for nullary3d achieved 🎉

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Jul 14, 2024
kgryte
kgryte requested changes Jul 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@headlessNode Left a few comments. I suggest doing another pass to sanity check the strides.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jul 14, 2024
@headlessNode
Copy link
Contributor Author

@kgryte The strides with blockSize went a little over my head. Hopefully, I'll get the hang of it when implementing the remaining tests. Thanks for your guidance.

@kgryte
Apply suggestions from code review
9e5f5a1 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jul 15, 2024
@kgryte kgryte merged commit 9abdead into stdlib-js:develop Jul 15, 2024
6 checks passed
@kgryte kgryte changed the title test: add tests to @stdlib/ndarray/base/nullary/test/test.3d.js test: add tests to ndarray/base/nullary Jul 15, 2024
@headlessNode headlessNode deleted the nullary-tests-3d branch July 15, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headlessNode @kgryte