Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add at, fill, filter, toLocalestring to array/bool #2607

Merged
merged 8 commits into from
Jul 15, 2024
Merged

feat: add at, fill, filter, toLocalestring to array/bool #2607

merged 8 commits into from
Jul 15, 2024

Conversation

Jaysukh-409
Copy link
Member

Resolves: Subtask of #2304

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array at, fill, filter and toLocaleString methods to prototype of BooleanArray

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Jaysukh-409 Jaysukh-409 added the Feature Issue or pull request for adding a new feature. label Jul 15, 2024
@Jaysukh-409 Jaysukh-409 marked this pull request as ready for review July 15, 2024 16:23
@kgryte
Apply suggestions from code review
4fe0669 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
324f697 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
8893f64 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
49a1096 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
d3c5e44 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
1947a47 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
92a3dde 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit 7c17308 into stdlib-js:develop Jul 15, 2024
8 checks passed
@kgryte kgryte deleted the array/bool branch July 15, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte