Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copyWithin, entries, forEach to array/bool #2611

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

Jaysukh-409
Copy link
Member

Resolves: Subtask of #2304

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array copyWithin, forEach and entries methods to prototype of BooleanArray

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Jaysukh-409 Jaysukh-409 added the Feature Issue or pull request for adding a new feature. label Jul 16, 2024
@Jaysukh-409 Jaysukh-409 marked this pull request as ready for review July 16, 2024 14:44
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409.

@kgryte kgryte merged commit cb20ecc into stdlib-js:develop Jul 19, 2024
8 checks passed
@kgryte kgryte deleted the copyWithin/entries/forEach branch July 19, 2024 09:36
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2611
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants