Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests to ndarray/base/nullary #2634

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

headlessNode
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • add tests to @stdlib/ndarray/base/nullary/test/test.5d.js for 100% test coverage

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@headlessNode
Copy link
Contributor Author

@kgryte please review, thanks.

Snehil-Shah pushed a commit to Snehil-Shah/stdlib that referenced this pull request Jul 20, 2024
PR-URL: stdlib-js#2634
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@kgryte kgryte added the Tests Pull requests specifically adding tests. label Jul 21, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit 06b4d43 into stdlib-js:develop Jul 21, 2024
6 checks passed
@headlessNode headlessNode deleted the nullary-tests-5d branch July 21, 2024 02:10
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2634
Ref: stdlib-js#2229
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Pull requests specifically adding tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants