test: add tests to ndarray/base/nullary
#2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kgryte Please review, thanks. |
kgryte
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
LGTM. Thanks, @headlessNode.
Just a heads up that you'll want to run test coverage locally using the make test-cov TESTS_FILTER="..." command. A change I had to make was to ensure that the bsize*2 dimension was not preceded by a singleton dimension; otherwise, the strides won't sort in a manner such that all dimensions exercise blocking branches. Something to keep in mind for 9D and beyond.
|
@kgryte Thanks for the heads up. |
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2652 Ref: stdlib-js#2229 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2229.
Description
This pull request:
@stdlib/ndarray/base/nullary/test/test.8d.jsfor 100% test coverageRelated Issues
This pull request:
@stdlib/ndarray/base/nullary#2229Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers