feat: add lapack/base/dpotf2
#2771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
Pranavchiku
commented
Aug 10, 2024
lib/node_modules/@stdlib/lapack/base/dpotf2/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Pranavchiku
commented
Aug 10, 2024
lib/node_modules/@stdlib/lapack/base/dpotf2/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
Pranavchiku
commented
Aug 10, 2024
Pranavchiku
commented
Aug 10, 2024
Pranavchiku
commented
Aug 10, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
kgryte
reviewed
Sep 17, 2024
| var sa1; | ||
| var j; | ||
|
|
||
| upper = ( uplo === 'upper' ); |
There was a problem hiding this comment.
I don't believe this temporary variable is necessary. Just inline at L75.
kgryte
reviewed
Sep 17, 2024
| if ( upper ) { | ||
| for ( j = 0; j < N; j++ ) { | ||
| // Compute U( j, j ) and test for non-positive-definiteness... | ||
| ajj = A[ offsetA + ( j * sa1 ) + ( j * sa0 ) ] - ddot( j, A, sa1, offsetA + ( j * sa0 ), A, sa1, offsetA + ( j * sa0 ) ); |
There was a problem hiding this comment.
You have a lot of repeated computation of index offsets. Refactor to reduce flops.
kgryte
reviewed
Sep 17, 2024
| } | ||
| }); | ||
|
|
||
| tape( 'the function supports accessing elements from non-contiguous rows and columns ( row-major )', function test( t ) { |
There was a problem hiding this comment.
You need more systematic tests. And also, you only include row-major tests here. What about column-major behavior?
kgryte
added
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation of
lapack/base/dpotf2Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers