Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add is-same-typed-array-like #2939

Merged
merged 4 commits into from
Oct 8, 2024
Merged

feat: add is-same-typed-array-like #2939

merged 4 commits into from
Oct 8, 2024

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Sep 23, 2024 •
edited
Loading

Resolves #2887

Description

What is the purpose of this pull request?

This pull request:

  • adds is-same-typed-array-like

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. Feature Issue or pull request for adding a new feature. and removed Accepted RFC feature request which has been accepted. labels Sep 24, 2024
@adityacodes30
Copy link
Contributor Author

pr is ready to be reviewed @kgryte @Planeshifter . Thank You !

Planeshifter
Planeshifter approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adityacodes30 for your PR and @Jaysukh-409 for initial review. Will merge shortly after having made some small edits.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Oct 8, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 8, 2024 •
edited by Planeshifter
Loading

PR Commit Message

feat: add `assert/is-same-typed-array-like`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2939
Closes: https://github.com/stdlib-js/stdlib/issues/2887

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Jaysukh Makvana <jaysukhmakvana2004@gmail.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4927336 into stdlib-js:develop Oct 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Jaysukh-409 Jaysukh-409 Awaiting requested review from Jaysukh-409

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/assert/is-same-typed-array-like
5 participants
@adityacodes30 @stdlib-bot @Planeshifter @Jaysukh-409 @kgryte