Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit popular OS libraries #33

Closed
matthewp opened this issue Mar 13, 2015 · 13 comments
Closed

Audit popular OS libraries #33

matthewp opened this issue Mar 13, 2015 · 13 comments

Comments

@matthewp
Copy link
Member

Should do an audit of popular open source libraries and make sure they work. I've tested a few that did not, such as Mocha.

@matthewp
Copy link
Member Author

This audit is based on the top Bower packages sorted by stars. They are installed from npm, of course. I couldn't find a listing of the top NPM browser modules. Will do another audit if a better list can be found.

@matthewp
Copy link
Member Author

These are just some other popular libraries I thought of:

@wclr
Copy link
Contributor

wclr commented Mar 20, 2015

Minilog. not so popular but. https://github.com/mixu/minilog tries to load node version in browser
so it needs to be mapped to "minilog/lib/web/index.js",

@matthewp
Copy link
Member Author

@whitecolor Thanks! It should work if their package.json has:

{
  "browser": "./lib/web/console.js"
}

This would also make it work with browserify. Should file an issue for them to add that.

@wclr
Copy link
Contributor

wclr commented Mar 20, 2015

Ok
mixu/minilog#24

@matthewp
Copy link
Member Author

Great, hope they merge.

@mixu
Copy link

mixu commented Mar 20, 2015

Boom, merged! Thanks.

@matthewp
Copy link
Member Author

Looks like it's working, thanks @mixu !

@wclr
Copy link
Contributor

wclr commented Mar 28, 2015

Try to load less in browser `(https://github.com/less/less.js/blob/master/package.json)

it tries to load package dependecies why?

@matthewp
Copy link
Member Author

Not sure I understand your question. The reason it doesn't work is because its main points to the Node code. #40 would fix it. PRs welcome.

@wclr
Copy link
Contributor

wclr commented Mar 28, 2015

I tried with forked version with "browser": "./dist/less.js" field and steal tries load less.js package.json deps.

@matthewp
Copy link
Member Author

@whitecolor Created #41 to track that issue.

@matthewp
Copy link
Member Author

matthewp commented Apr 8, 2015

Ah @whitecolor :) less/less.js@7cc986e

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants