-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to NPM #9354
Comments
in it's current state it wouldn't attach dependencies properly, as jquery and handlebars both don't expose themselves when used as commonJS iirc i'd also like to get the tests passing with them #9328 |
I personally don't even care if it supports CJS. Just having the artifacts in NPM helps so people don't have to deal with Bower. |
i'm working on it as i have time. i'd like to do it to make it a nice browserify experience. i'll probably get something in before or just after the 1.8 release. |
@fivetanley also it would be nice to have separate |
@fivetanley awesome! How's it going? |
@wagenet just got through one of the busiest weeks of my life. :) i usually reserve most of wednesday for open source days, but we're getting training ready. i'll be back on this either tomorrow or on next saturday depending on how much energy i have left tomorrow. But this is something I want to get in soon. @knownasilya can I bug you to help QA this? |
@fivetanley Sure, feel free to ping me here or on irc, tweet at me or email
|
FWIW, I think it would be completely reasonable to publish with the caveat that Handlebars and jQuery are expected to be globally available, because that is easily accomplished with browserify-shim. |
Although both are available on npm, and shouldn't have to be shimmed.
|
Right, I was referring to the comment above that "query and handlebars both don't expose themselves when used as commonJS iirc" which I believe is correct. If Ember expects them to be globally available, shimming would be an option. |
The better alternative would be to patch ember for it to first try to load via other means, and globals being the last option if not loaded. Although there could be performance issues with this (adding file size to ember). |
pinging @ef4 from a related conversation we've add |
This happened in 2.10. Closing this. Thank you all! |
It seems like all the pieces are pretty much there and are being pushed to https://github.com/components/ember. Just need a script to publish the thing. Am I missing something?
The text was updated successfully, but these errors were encountered: