Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to NPM #9354

Closed
chadhietala opened this issue Oct 17, 2014 · 14 comments
Closed

Publish to NPM #9354

chadhietala opened this issue Oct 17, 2014 · 14 comments
Assignees
Labels

Comments

@chadhietala
Copy link
Contributor

It seems like all the pieces are pretty much there and are being pushed to https://github.com/components/ember. Just need a script to publish the thing. Am I missing something?

@fivetanley
Copy link
Member

in it's current state it wouldn't attach dependencies properly, as jquery and handlebars both don't expose themselves when used as commonJS iirc

i'd also like to get the tests passing with them #9328

@chadhietala
Copy link
Contributor Author

I personally don't even care if it supports CJS. Just having the artifacts in NPM helps so people don't have to deal with Bower.

@fivetanley
Copy link
Member

i'm working on it as i have time. i'd like to do it to make it a nice browserify experience. i'll probably get something in before or just after the 1.8 release.

@vkurchatkin
Copy link

@fivetanley also it would be nice to have separate ember-runtime package for node and browserify

@wagenet
Copy link
Member

wagenet commented Nov 1, 2014

@fivetanley awesome! How's it going?

@fivetanley
Copy link
Member

@wagenet just got through one of the busiest weeks of my life. :)

i usually reserve most of wednesday for open source days, but we're getting training ready. i'll be back on this either tomorrow or on next saturday depending on how much energy i have left tomorrow. But this is something I want to get in soon.

@knownasilya can I bug you to help QA this?

@wagenet
Copy link
Member

wagenet commented Nov 2, 2014

@fivetanley 👍

@knownasilya
Copy link
Contributor

@fivetanley Sure, feel free to ping me here or on irc, tweet at me or email
me.
On Nov 1, 2014 9:05 PM, "Stanley Stuart" notifications@github.com wrote:

@wagenet https://github.com/wagenet just got through one of the busiest
weeks of my life. :)

i usually reserve most of wednesday for open source days, but we're
getting training ready. i'll be back on this either tomorrow or on next
saturday depending on how much energy i have left tomorrow. But this is
something I want to get in soon.

@knownasilya https://github.com/knownasilya can I bug you to help QA
this?


Reply to this email directly or view it on GitHub
#9354 (comment).

@bclinkinbeard
Copy link

FWIW, I think it would be completely reasonable to publish with the caveat that Handlebars and jQuery are expected to be globally available, because that is easily accomplished with browserify-shim.

@knownasilya
Copy link
Contributor

Although both are available on npm, and shouldn't have to be shimmed.
On Nov 7, 2014 5:19 PM, "Ben Clinkinbeard" notifications@github.com wrote:

FWIW, I think it would be completely reasonable to publish with the caveat
that Handlebars and jQuery are expected to be globally available, because
that is easily accomplished with browserify-shim.


Reply to this email directly or view it on GitHub
#9354 (comment).

@bclinkinbeard
Copy link

Right, I was referring to the comment above that "query and handlebars both don't expose themselves when used as commonJS iirc" which I believe is correct. If Ember expects them to be globally available, shimming would be an option.

@knownasilya
Copy link
Contributor

The better alternative would be to patch ember for it to first try to load via other means, and globals being the last option if not loaded. Although there could be performance issues with this (adding file size to ember).

@locks
Copy link
Contributor

locks commented Apr 15, 2016

pinging @ef4 from a related conversation we've add

@Serabe
Copy link
Member

Serabe commented Mar 3, 2017

This happened in 2.10. Closing this.

Thank you all!

@Serabe Serabe closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants