Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print free memory #642

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Print free memory #642

merged 1 commit into from
Dec 2, 2016

Conversation

theoreticalbts
Copy link
Contributor

Fix #635

@abitmore
Copy link
Contributor

abitmore commented Dec 1, 2016

Possible issues of the implementation:

  1. when starting the node, if free memory is less than 2GB, _last_free_gb_printed will keep 0 and no message will be printed ever.
  2. assume not in case of above situation, it will print only one message when free memory dropped below 1GB, which will likely get ignored. I think it's better to print more after that.
  3. default console log level is warn, using ilog here doesn't help much

@theoreticalbts theoreticalbts reopened this Dec 2, 2016
@mvandeberg mvandeberg merged commit e2d4809 into develop Dec 2, 2016
@mvandeberg mvandeberg deleted the 635-print-free-memory branch December 2, 2016 21:10
@abitmore abitmore mentioned this pull request Dec 3, 2016
Closed
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this pull request May 28, 2018
@afalaleev
Merge pull request steemit#642 from GolosChain/641-cli_wallet-proposa…
0302b59 
…ls-nesting

Ability to create nesting proposals with cli_wallet steemit#641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandeberg mvandeberg mvandeberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theoreticalbts @abitmore @mvandeberg