Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable extra installed tests #873

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

elmarco
Copy link
Contributor

@elmarco elmarco commented Jul 16, 2024

No description provided.

@elmarco elmarco force-pushed the installed-tests branch 2 times, most recently from 2380dff to d5c0833 Compare July 16, 2024 19:29
@stefanberger
Copy link
Owner

Can you please rebase.

All of these work fine (run as non-root):

$ ./installed-runner.sh
$ SWTPM_TEST_EXPENSIVE=1 ./installed-runner.sh
$ SWTPM_TEST_EXPENSIVE=1 SWTPM_TEST_IBMTSS=1 ./installed-runner.sh

I saw test_tpm12 failing due to the following but then also passing at least once -- probably the git clone didn't work:

./test_tpm12: line 80: ./patches/libtpm.patch: No such file or directory

The following tests are still being skipped:

SKIP: test_tpm2_save_load_state_2
SKIP: test_tpm2_save_load_state_2_linear
SKIP: test_tpm2_save_load_state_2_block
SKIP: test_tpm2_save_load_state_3

@elmarco
Copy link
Contributor Author

elmarco commented Aug 26, 2024

The following tests are still being skipped:

You still need SWTPM_TEST_IBMTSS2=1.

To run against an installed IBM TSS test suite, you may set the
SWTPM_TEST_IBMTSS to the location of the test suite, such as
/usr/libexec/installed-tests/ibmtss.

@stefanberger
Copy link
Owner

#892 should go in before this one.

Run against the installed version only when SWTPM_TEST_IBMTSS is
set to the directory that has the tests, otherwise, build the known
version.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Use an absolute path for TESTDIR, as we refer to it from different
directories.

Also fix killing gone swtpm process.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
@elmarco
Copy link
Contributor Author

elmarco commented Aug 27, 2024

#892 should go in before this one.

there isn't much left after the rebase, thanks

@stefanberger
Copy link
Owner

#892 should go in before this one.

there isn't much left after the rebase, thanks

I think it's quite complete now...

@stefanberger stefanberger merged commit fe4b82c into stefanberger:master Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants